Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Archive Migrations] dashboard/feature_controls/spaces #139342

Conversation

wayneseymour
Copy link
Member

@wayneseymour wayneseymour commented Aug 24, 2022

Summary

Replaces the old es archive with kbn archive.
Change test to use new archive.

Helps with: #102552

Details

Add space.id back to spacesService.create().
In the can view existing Dashboard test, switch to id instead of name.

@wayneseymour wayneseymour self-assigned this Aug 24, 2022
@wayneseymour wayneseymour added test_xpack_functional v8.5.0 backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes labels Aug 24, 2022
@wayneseymour wayneseymour force-pushed the migrations/dashboard-feature-controls-spaces branch 2 times, most recently from fbd793d to 8885ec2 Compare August 26, 2022 13:31
Replaces the old es archive with kbn archive.
Change test to use new archive.

Helps with: elastic#102552
@wayneseymour wayneseymour force-pushed the migrations/dashboard-feature-controls-spaces branch from 8885ec2 to d59e452 Compare September 1, 2022 07:40
@wayneseymour wayneseymour marked this pull request as ready for review September 1, 2022 09:31
Copy link

@LeeDr LeeDr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - code review only

Copy link
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this is the only place the x-pack/test/functional/es_archives/dashboard/feature_controls/spaces archive is used, we should delete it in this PR right?

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @wayneseymour

@wayneseymour wayneseymour merged commit 677390d into elastic:main Sep 1, 2022
@wayneseymour wayneseymour deleted the migrations/dashboard-feature-controls-spaces branch September 6, 2022 07:28
Mpdreamz pushed a commit to Mpdreamz/kibana that referenced this pull request Sep 6, 2022
* [Archive Migrations] dashboard/feature_controls/spaces

Replaces the old es archive with kbn archive.
Change test to use new archive.

Helps with: elastic#102552

* Whoops, forgot to drop the archive.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes test_xpack_functional v8.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants