-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Archive Migrations] dashboard/feature_controls/spaces #139342
[Archive Migrations] dashboard/feature_controls/spaces #139342
Conversation
fbd793d
to
8885ec2
Compare
Replaces the old es archive with kbn archive. Change test to use new archive. Helps with: elastic#102552
8885ec2
to
d59e452
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - code review only
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this is the only place the x-pack/test/functional/es_archives/dashboard/feature_controls/spaces
archive is used, we should delete it in this PR right?
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
* [Archive Migrations] dashboard/feature_controls/spaces Replaces the old es archive with kbn archive. Change test to use new archive. Helps with: elastic#102552 * Whoops, forgot to drop the archive.
Summary
Replaces the old es archive with kbn archive.
Change test to use new archive.
Helps with: #102552
Details
Add
space.id
back tospacesService.create()
.In the
can view existing Dashboard
test, switch to id instead of name.