-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS] Updates getting started for Maps #139050
Conversation
Pinging @elastic/kibana-docs (Team:Docs) |
+ | ||
[role="screenshot"] | ||
image::maps/images/gs_dashboard_with_map.png[] | ||
image::maps/images/gs_dashboard_with_map.png[Map in a dashboard with 2 other panels] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This image should be taken before the filter is applied. Right now, its taken after the filter is applied.
Your filtered map should look similar to this: | ||
|
||
[role="screenshot"] | ||
image::maps/images/gs_dashboard_with_map.png[Map showing filtered data] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should use a different image then gs_dashboard_with_map.png so users can see the difference of applying the filter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating the getting started docs!
Nit: docs/maps/images/gs_add_cloropeth_layer.png has light blue color ramp while instructions say to use "grey" color ramp. Other screen shots show layer with "grey" color ramp
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for updating the images and copy to be up to date with current Kibana.
* [DOCS] Updates getting started for Maps * [DOCS] Updates images as per review comments (cherry picked from commit 89d8802)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
) * [DOCS] Updates getting started for Maps * [DOCS] Updates images as per review comments (cherry picked from commit 89d8802) Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
* [DOCS] Updates getting started for Maps * [DOCS] Updates images as per review comments
Summary
This PR:
Preview:
https://kibana_139050.docs-preview.app.elstc.co/guide/en/kibana/master/maps-getting-started.html