Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Updates getting started for Maps #139050

Merged
merged 2 commits into from
Aug 18, 2022

Conversation

gchaps
Copy link
Contributor

@gchaps gchaps commented Aug 17, 2022

Summary

This PR:

  • Refreshes the images and text in the Maps getting started doc.
  • Adds alt text for screen readers.

Preview:
https://kibana_139050.docs-preview.app.elstc.co/guide/en/kibana/master/maps-getting-started.html

@gchaps gchaps added Team:Docs release_note:skip Skip the PR/issue when compiling release notes v8.4.0 v8.5.0 labels Aug 17, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-docs (Team:Docs)

@gchaps gchaps requested a review from nreese August 17, 2022 21:14
+
[role="screenshot"]
image::maps/images/gs_dashboard_with_map.png[]
image::maps/images/gs_dashboard_with_map.png[Map in a dashboard with 2 other panels]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This image should be taken before the filter is applied. Right now, its taken after the filter is applied.

Your filtered map should look similar to this:

[role="screenshot"]
image::maps/images/gs_dashboard_with_map.png[Map showing filtered data]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should use a different image then gs_dashboard_with_map.png so users can see the difference of applying the filter.

Copy link
Contributor

@nreese nreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the getting started docs!

Nit: docs/maps/images/gs_add_cloropeth_layer.png has light blue color ramp while instructions say to use "grey" color ramp. Other screen shots show layer with "grey" color ramp

@gchaps gchaps requested a review from nreese August 18, 2022 16:26
@gchaps gchaps added the auto-backport Deprecated - use backport:version if exact versions are needed label Aug 18, 2022
Copy link
Contributor

@nreese nreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for updating the images and copy to be up to date with current Kibana.

@gchaps gchaps merged commit 89d8802 into elastic:main Aug 18, 2022
@gchaps gchaps deleted the docs/update-maps-tutorial branch August 18, 2022 17:56
kibanamachine pushed a commit that referenced this pull request Aug 18, 2022
* [DOCS] Updates getting started for Maps

* [DOCS] Updates images as per review comments

(cherry picked from commit 89d8802)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.4

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Aug 18, 2022
)

* [DOCS] Updates getting started for Maps

* [DOCS] Updates images as per review comments

(cherry picked from commit 89d8802)

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
Mpdreamz pushed a commit to Mpdreamz/kibana that referenced this pull request Sep 6, 2022
* [DOCS] Updates getting started for Maps

* [DOCS] Updates images as per review comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Docs v8.4.0 v8.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants