-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tabify responeHandler for table #13877
Conversation
jenkins, test this |
this will need a rebase to get the new license check in. can you create an improvement ticket for replacing the tagcloud/regionmap response handlers? |
4ac0c1b
to
fdcdad0
Compare
@thomasneirynck i created an issue to track tag cloud and region map progress: #13940 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
jenkins, test this |
1 similar comment
jenkins, test this |
lgtm pending green CI. markdown failure seems like a fluke. |
jenkins, test this |
fdcdad0
to
a97dfdb
Compare
* adding tabify response handler * tabify should be the default response handler * asAggResultConfig should be configurable for BWC * update table to work with new tabify response handler * region map needs to define responseHandler: none * fixing tests * markdown should set responseHandler to none
* adding tabify response handler * tabify should be the default response handler * asAggResultConfig should be configurable for BWC * update table to work with new tabify response handler * region map needs to define responseHandler: none * fixing tests * markdown should set responseHandler to none
This reverts commit 622dd36.
* adding tabify response handler * tabify should be the default response handler * asAggResultConfig should be configurable for BWC * update table to work with new tabify response handler * region map needs to define responseHandler: none * fixing tests * markdown should set responseHandler to none
* adding tabify response handler * tabify should be the default response handler * asAggResultConfig should be configurable for BWC * update table to work with new tabify response handler * region map needs to define responseHandler: none * fixing tests * markdown should set responseHandler to none
table should not import tabify but should use tabify respose handler.
tag cloud and region map should probably do the sameactually both should be using point series response handler with dimensions like x for text and y for font size (text, color for regionmap) ... we should avoid using pure es data in visualizations