Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Enable kibana build reuse where possible #136653

Merged
merged 7 commits into from
Aug 2, 2022
Merged

[CI] Enable kibana build reuse where possible #136653

merged 7 commits into from
Aug 2, 2022

Conversation

brianseeders
Copy link
Contributor

@brianseeders brianseeders commented Jul 19, 2022 •
edited by kibanamachine
Loading

  • Reuse kibana build distributable / plugins whenever possible on all PRs
  • Add annotation whenever a build is reused
  • Send backfill job ID to ci-stats, to re-use metrics from reused build step

Screen Shot 2022-08-02 at 2 45 15 PM

@brianseeders brianseeders added Feature:CI Continuous integration release_note:skip Skip the PR/issue when compiling release notes backport:auto-version Team:Operations Team label for Operations Team ci:reuse-kibana-build Experimental labels Jul 19, 2022
@brianseeders
Copy link
Contributor Author

buildkite test this

2 similar comments
@brianseeders
Copy link
Contributor Author

buildkite test this

@brianseeders
Copy link
Contributor Author

buildkite test this

@brianseeders
Copy link
Contributor Author

buildkite test this

2 similar comments
@brianseeders
Copy link
Contributor Author

buildkite test this

@brianseeders
Copy link
Contributor Author

buildkite test this

@brianseeders brianseeders changed the title Testing kibana build reuse feature [CI] Enable kibana build reuse where possible Aug 2, 2022
@brianseeders
Copy link
Contributor Author

buildkite test this

@brianseeders brianseeders added backport:prev-minor Backport to (9.0) the previous minor version (i.e. one version back from main) and removed backport:auto-version labels Aug 2, 2022
@brianseeders brianseeders marked this pull request as ready for review August 2, 2022 18:51
@brianseeders brianseeders requested a review from a team as a code owner August 2, 2022 18:51
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

spalger
spalger approved these changes Aug 2, 2022
View reviewed changes
Copy link
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@brianseeders brianseeders merged commit a74c3fa into elastic:main Aug 2, 2022
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Aug 2, 2022
@brianseeders
[CI] Enable kibana build reuse where possible (elastic#136653)
398f09f 
(cherry picked from commit a74c3fa)
@kibanamachine kibanamachine mentioned this pull request Aug 2, 2022
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.4

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@brianseeders
Copy link
Contributor Author

I realized right after merging this that I need to allow the changes in this PR to get merged into other open PRs before enabling the feature, otherwise they will fail with ci-stats reports. I temporarily reverted one line of this PR directly in main: 5b1e073

kibanamachine added a commit that referenced this pull request Aug 2, 2022
@kibanamachine @brianseeders
[CI] Enable kibana build reuse where possible (#136653) (#137910)
f22bf8d 
(cherry picked from commit a74c3fa)

Co-authored-by: Brian Seeders <brian.seeders@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spalger spalger spalger approved these changes

Assignees
No one assigned
Labels
backport:prev-minor Backport to (9.0) the previous minor version (i.e. one version back from main) ci:reuse-kibana-build Experimental Feature:CI Continuous integration release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v8.4.0 v8.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@brianseeders @elasticmachine @kibana-ci @kibanamachine @spalger