Remove deprecated es-query re-imports from data plugin #134600

Dosant · 2022-06-16T19:21:48Z

Summary

Close #119356, #124069

Cleaning up leftovers to remove deprecated re-imports from data plugin

…ta-deprecations-clean

Dosant · 2022-06-17T10:21:05Z

x-pack/plugins/osquery/public/common/hooks/use_discover_link.tsx

@@ -7,7 +7,7 @@

 import { useCallback, useEffect, useState } from 'react';

-import { FilterStateStore } from '@kbn/data-plugin/common';
+import { FilterStateStore } from '@kbn/es-query';


I think we should refactor FilterStateStore from enum to a type so that osquery (and probably other places) avoid importing '@kbn/es-query' into their bundle just for this

elasticmachine · 2022-06-17T10:56:51Z

Pinging @elastic/kibana-app-services (Team:AppServicesSv)

elasticmachine · 2022-06-17T11:10:49Z

Pinging @elastic/apm-ui (Team:apm)

elasticmachine · 2022-06-17T11:10:49Z

Pinging @elastic/fleet (Team:Fleet)

elasticmachine · 2022-06-17T11:10:49Z

Pinging @elastic/uptime (Team:uptime)

kertal

LGTM, just change of imports, did not test

ThomThomson

Presentation team import changes LGTM!

…ta-deprecations-clean

patrykkopycinski

LGTM, Thank you! @Dosant

nchaulet

Fleet changes 🚀

ymao1

Response Ops changes LGTM. Code review only.

nreese

kibana-gis changes LGTM
code review

gbamparop

APM changes LGTM!

darnautov

ML, Transform and Data Visualizer changes LGTM

weltenwort

infra and monitoring plugin changes LGTM, thank you

mattkime

changes lgtm

sorenlouv

apm changes lgtm

lukasolson

LGTM!

…ta-deprecations-clean

kibana-ci · 2022-06-21T11:09:44Z

💛 Build succeeded, but was flaky

Failed CI Steps

Osquery Cypress Tests

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`apm`	1232	1293	+61
`data`	513	512	-1
`osquery`	263	324	+61
total			+121

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`data`	2518	2399	-119

Any counts in public APIs

Total count of every any typed public API. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats any for more detailed information.

id	before	after	diff
`data`	35	34	-1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`apm`	2.9MB	2.9MB	+27.3KB
`lens`	1.2MB	1.2MB	-4.0B
`ml`	3.3MB	3.3MB	+5.0B
`osquery`	1.0MB	1.0MB	+26.4KB
total			+53.7KB

Canvas Sharable Runtime

The Canvas "shareable runtime" is an bundle produced to enable running Canvas workpads outside of Kibana. This bundle is included in third-party webpages that embed canvas and therefor should be as slim as possible.

id	before	after	diff
`module count`	4955	4954	-1

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id	before	after	diff
`data`	21	22	+1
`kibana`	382	371	-11
total			-10

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`data`	423.7KB	417.0KB	-6.7KB
`osquery`	16.3KB	16.3KB	+50.0B
total			-6.6KB

Unknown metric groups

API count

id	before	after	diff
`data`	3372	3072	-300

ESLint disabled in files

id	before	after	diff
`data`	4	2	-2

ESLint disabled line counts

id	before	after	diff
`maps`	40	38	-2

References to deprecated APIs

id	before	after	diff
`apm`	32	29	-3
`canvas`	79	52	-27
`cases`	12	0	-12
`controls`	18	0	-18
`dashboard`	119	29	-90
`dashboardEnhanced`	6	0	-6
`dataVisualizer`	24	0	-24
`discover`	60	18	-42
`discoverEnhanced`	6	0	-6
`fleet`	28	19	-9
`infra`	34	1	-33
`lens`	47	14	-33
`maps`	155	17	-138
`ml`	63	21	-42
`monitoring`	15	3	-12
`securitySolution`	82	64	-18
`uiActionsEnhanced`	45	0	-45
`urlDrilldown`	36	0	-36
`visDefaultEditor`	24	0	-24
`visTypeTimelion`	12	0	-12
`visTypeTimeseries`	18	12	-6
`visTypeVega`	21	0	-21
`visualizations`	34	13	-21
total			-678

Total ESLint disabled count

id	before	after	diff
`data`	64	62	-2
`maps`	68	66	-2
total			-4

Unreferenced deprecated APIs

id	before	after	diff
`data`	62	5	-57

History

💚 Build #51763 succeeded 739e8e1
💛 Build #51508 was flaky d4ffba9
💔 Build #51490 failed 9861259
💔 Build #51432 failed 751752d

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Dosant added 4 commits June 16, 2022 21:21

clean up data plugin imports

751752d

remove no longer needed eslint mutes

3fe4878

fix dashboard bundle

9861259

Merge branch 'main' of github.com:elastic/kibana into d/2022-06-16-da…

d4ffba9

…ta-deprecations-clean

Dosant commented Jun 17, 2022

View reviewed changes

Dosant mentioned this pull request Jun 17, 2022

[Filters] Refactor FilterStateStore from enum to a type #134648

Open

Dosant changed the title ~~clean up data plugin imports~~ Remove deprecated es-query re-imports from data plugin Jun 17, 2022

Dosant added Feature:Search Querying infrastructure in Kibana Team:AppServicesSv v8.4.0 technical debt Improvement of the software architecture and operational architecture release_note:skip Skip the PR/issue when compiling release notes labels Jun 17, 2022

Dosant marked this pull request as ready for review June 17, 2022 10:56

Dosant requested review from a team as code owners June 17, 2022 10:56

shahzad31 approved these changes Jun 17, 2022

View reviewed changes

botelastic bot added Feature:Drilldowns Embeddable panel Drilldowns Team:APM All issues that need APM UI Team support labels Jun 17, 2022

botelastic bot added Team:Fleet Team label for Observability Data Collection Fleet team Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability labels Jun 17, 2022

kertal approved these changes Jun 17, 2022

View reviewed changes

flash1293 approved these changes Jun 17, 2022

View reviewed changes

ThomThomson approved these changes Jun 17, 2022

View reviewed changes

Merge branch 'main' of github.com:elastic/kibana into d/2022-06-16-da…

739e8e1

…ta-deprecations-clean

patrykkopycinski approved these changes Jun 20, 2022

View reviewed changes

nchaulet approved these changes Jun 20, 2022

View reviewed changes

ymao1 approved these changes Jun 20, 2022

View reviewed changes

nreese approved these changes Jun 20, 2022

View reviewed changes

gbamparop approved these changes Jun 20, 2022

View reviewed changes

darnautov approved these changes Jun 20, 2022

View reviewed changes

weltenwort self-requested a review June 20, 2022 15:41

weltenwort approved these changes Jun 20, 2022

View reviewed changes

mattkime approved these changes Jun 20, 2022

View reviewed changes

sorenlouv approved these changes Jun 20, 2022

View reviewed changes

lukasolson approved these changes Jun 20, 2022

View reviewed changes

Merge branch 'main' of github.com:elastic/kibana into d/2022-06-16-da…

ecb8126

…ta-deprecations-clean

Dosant enabled auto-merge (squash) June 21, 2022 11:03

Dosant merged commit a8095ce into elastic:main Jun 21, 2022

kibanamachine added the backport:skip This commit does not require backporting label Jun 21, 2022

Dosant mentioned this pull request Jun 21, 2022

[APM] Replace deprecated import of esKuery from the data plugin #124069

Closed

patrykkopycinski pushed a commit to patrykkopycinski/kibana that referenced this pull request Jun 22, 2022

Remove deprecated es-query re-imports from data plugin (elastic#134600)

c6978b0

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove deprecated es-query re-imports from data plugin #134600

Remove deprecated es-query re-imports from data plugin #134600

Dosant commented Jun 16, 2022 •

edited

Loading

Dosant Jun 17, 2022

Dosant Jun 17, 2022

elasticmachine commented Jun 17, 2022

elasticmachine commented Jun 17, 2022

elasticmachine commented Jun 17, 2022

elasticmachine commented Jun 17, 2022

kertal left a comment

ThomThomson left a comment

patrykkopycinski left a comment

nchaulet left a comment

ymao1 left a comment

nreese left a comment

gbamparop left a comment

darnautov left a comment

weltenwort left a comment

mattkime left a comment

sorenlouv left a comment

lukasolson left a comment

kibana-ci commented Jun 21, 2022

API count

ESLint disabled in files

ESLint disabled line counts

References to deprecated APIs

Total ESLint disabled count

Unreferenced deprecated APIs

Remove deprecated es-query re-imports from data plugin #134600

Remove deprecated es-query re-imports from data plugin #134600

Conversation

Dosant commented Jun 16, 2022 • edited Loading

Summary

Dosant Jun 17, 2022

Choose a reason for hiding this comment

Dosant Jun 17, 2022

Choose a reason for hiding this comment

elasticmachine commented Jun 17, 2022

elasticmachine commented Jun 17, 2022

elasticmachine commented Jun 17, 2022

elasticmachine commented Jun 17, 2022

kertal left a comment

Choose a reason for hiding this comment

ThomThomson left a comment

Choose a reason for hiding this comment

patrykkopycinski left a comment

Choose a reason for hiding this comment

nchaulet left a comment

Choose a reason for hiding this comment

ymao1 left a comment

Choose a reason for hiding this comment

nreese left a comment

Choose a reason for hiding this comment

gbamparop left a comment

Choose a reason for hiding this comment

darnautov left a comment

Choose a reason for hiding this comment

weltenwort left a comment

Choose a reason for hiding this comment

mattkime left a comment

Choose a reason for hiding this comment

sorenlouv left a comment

Choose a reason for hiding this comment

lukasolson left a comment

Choose a reason for hiding this comment

kibana-ci commented Jun 21, 2022

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Module Count

Public APIs missing comments

Any counts in public APIs

Async chunks

Canvas Sharable Runtime

Public APIs missing exports

Page load bundle

API count

ESLint disabled in files

ESLint disabled line counts

References to deprecated APIs

Total ESLint disabled count

Unreferenced deprecated APIs

History

Dosant commented Jun 16, 2022 •

edited

Loading