Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Fix release fallback logic in Fleet package archive code #133626

Merged

Conversation

kpollich
Copy link
Member

@kpollich kpollich commented Jun 6, 2022

Summary

Ref elastic/package-spec#225
Ref elastic/package-registry#785
Ref #133270

Adds fallback logic based on the version value in an integration's manifest.yml to populate the release field when it is excluded from the manifest.yml file. Generation of the release value is based on whether the integration's release is a prerelease (per semver spec) or its major version is less than 1. See package spec issues and package registry PR referenced above for further context.

This should unblock #133270, which is failing because the latest APM package no longer includes a release value in its manifest.yml as of elastic/apm-server#7792.

@kpollich kpollich added release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team auto-backport Deprecated - use backport:version if exact versions are needed v8.3.0 v8.4.0 labels Jun 6, 2022
@kpollich kpollich requested a review from a team as a code owner June 6, 2022 14:10
@kpollich kpollich self-assigned this Jun 6, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

Copy link
Member

@nchaulet nchaulet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Is APM the only package impacted by this?

@kpollich
Copy link
Member Author

kpollich commented Jun 6, 2022

🚀 Is APM the only package impacted by this?

I ran the generatePackageInfoFromArchiveBuffer against the latest version of all other bundled packages and it seems APM is the only one where release has been formally removed from its manifest. So yes APM should be the only package affected so far.

@kpollich kpollich enabled auto-merge (squash) June 6, 2022 14:38
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @kpollich

@kpollich kpollich merged commit f6eafdd into elastic:main Jun 6, 2022
@kpollich kpollich deleted the fix-fleet-archive-release-validation branch June 6, 2022 18:49
kibanamachine pushed a commit that referenced this pull request Jun 6, 2022
…3626)

* Fix release fallback logic in Fleet package archive code

* Move release to optional

* Fix type

(cherry picked from commit f6eafdd)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.3

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jun 6, 2022
…3626) (#133662)

* Fix release fallback logic in Fleet package archive code

* Move release to optional

* Fix type

(cherry picked from commit f6eafdd)

Co-authored-by: Kyle Pollich <kyle.pollich@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.3.0 v8.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants