-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fleet] Fix release fallback logic in Fleet package archive code #133626
[Fleet] Fix release fallback logic in Fleet package archive code #133626
Conversation
Pinging @elastic/fleet (Team:Fleet) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 Is APM the only package impacted by this?
I ran the |
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: cc @kpollich |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
Summary
Ref elastic/package-spec#225
Ref elastic/package-registry#785
Ref #133270
Adds fallback logic based on the
version
value in an integration'smanifest.yml
to populate therelease
field when it is excluded from themanifest.yml
file. Generation of therelease
value is based on whether the integration's release is a prerelease (per semver spec) or its major version is less than 1. See package spec issues and package registry PR referenced above for further context.This should unblock #133270, which is failing because the latest APM package no longer includes a
release
value in itsmanifest.yml
as of elastic/apm-server#7792.