Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Add check for possible new FTR configs #132731

Merged
merged 1 commit into from
May 23, 2022

Conversation

brianseeders
Copy link
Contributor

@brianseeders brianseeders commented May 23, 2022

This check will catch most (but not all) new FTR configs that are added to the repo without being added to .buildkite/ftr_configs.yml. Several users have added new configs without adding them there, and I've done it a few times myself.

As of writing, when run against every file in the repo, it identifies about 90% of FTR configs with 0 false positives.

Also, the precommit hook is currently broken, because combineErrors was moved out of @kbn/dev-utils, so this fixes that as well.

@brianseeders brianseeders added Feature:CI Continuous integration release_note:skip Skip the PR/issue when compiling release notes v8.3.0 Team:Operations Team label for Operations Team labels May 23, 2022
@brianseeders brianseeders marked this pull request as ready for review May 23, 2022 17:11
@brianseeders brianseeders requested a review from a team as a code owner May 23, 2022 17:11
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/test 201 202 +1
Unknown metric groups

API count

id before after diff
@kbn/test 240 241 +1

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Member

@jbudz jbudz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it worth adding a CI check for this? LGTM as a standalone change too.

@brianseeders
Copy link
Contributor Author

Is it worth adding a CI check for this? LGTM as a standalone change too.

I've gone back and forth about adding a check against all files in the repo. I'm not sure if I want it to always run like that, especially since the check isn't 100% accurate.

The precommit hook checks do run as part of CI

@brianseeders brianseeders merged commit 0f696c8 into elastic:main May 23, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label May 23, 2022
@brianseeders brianseeders deleted the new-ftr-configs-check branch May 23, 2022 18:41
brianseeders added a commit that referenced this pull request May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:CI Continuous integration release_note:skip Skip the PR/issue when compiling release notes reverted Team:Operations Team label for Operations Team v8.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants