-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to enable compression for communications with ES #124009
Allow to enable compression for communications with ES #124009
Conversation
Pinging @elastic/kibana-core (Team:Core) |
💚 Build SucceededMetrics [docs]History
To update your PR or re-run it, just comment with: |
@@ -152,6 +152,9 @@ This value must be a positive integer. *Default: `30000`* | |||
| Time in milliseconds for {es} to wait for responses from shards. | |||
Set to 0 to disable. *Default: `30000`* | |||
|
|||
| `elasticsearch.compression:` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since you document it, we need to change the release_notes
label. Maybe to enhancements
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a few questions:
- Are you going to add it to allow-list it on Cloud any time soon?
- Could you create an issue to evaluate whether it is worth setting
compression: true
as the default value?
Not until we evaluate the impact of changing this value
I was planning to keep #117490 for this purpose, as I'm not closing the issue with this PR. Would you prefer to open a dedicated issue for it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
monitoring changes look good.
Summary
Part of #117490
Add a new
elasticsearch.compression
configuration property to allow configuration of the ES client'scompression
config value. The value defaults tofalse
, which is the default value used by the client when unspecified.Checklist
Release note
Add a new
elasticsearch.compression
configuration property to enable compression for communications between Kibana and Elasticsearch. This option default tofalse
.