Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to enable compression for communications with ES #124009

Merged
merged 6 commits into from
Feb 1, 2022

Conversation

pgayvallet
Copy link
Contributor

@pgayvallet pgayvallet commented Jan 28, 2022

Summary

Part of #117490

Add a new elasticsearch.compression configuration property to allow configuration of the ES client's compression config value. The value defaults to false, which is the default value used by the client when unspecified.

Checklist

Release note

Add a new elasticsearch.compression configuration property to enable compression for communications between Kibana and Elasticsearch. This option default to false.

@pgayvallet pgayvallet added Feature:elasticsearch release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v8.1.0 labels Jan 28, 2022
@pgayvallet pgayvallet marked this pull request as ready for review January 30, 2022 21:01
@pgayvallet pgayvallet requested review from a team as code owners January 30, 2022 21:01
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

API count

id before after diff
core 2353 2354 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@@ -152,6 +152,9 @@ This value must be a positive integer. *Default: `30000`*
| Time in milliseconds for {es} to wait for responses from shards.
Set to 0 to disable. *Default: `30000`*

| `elasticsearch.compression:`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you document it, we need to change the release_notes label. Maybe to enhancements?

Copy link
Contributor

@mshustov mshustov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few questions:

  • Are you going to add it to allow-list it on Cloud any time soon?
  • Could you create an issue to evaluate whether it is worth setting compression: true as the default value?

@pgayvallet
Copy link
Contributor Author

Are you going to add it to allow-list it on Cloud any time soon?

Not until we evaluate the impact of changing this value

Could you create an issue to evaluate whether it is worth setting compression: true as the default value?

I was planning to keep #117490 for this purpose, as I'm not closing the issue with this PR. Would you prefer to open a dedicated issue for it?

@pgayvallet pgayvallet added release_note:enhancement and removed release_note:skip Skip the PR/issue when compiling release notes labels Jan 31, 2022
Copy link
Contributor

@smith smith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

monitoring changes look good.

@pgayvallet pgayvallet merged commit 1eea7a3 into elastic:main Feb 1, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:elasticsearch release_note:enhancement Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v8.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants