[ML] Transforms: Support to set destination ingest pipeline. #123911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walterra
added
release_note:enhancement
:ml
Feature:Transforms
13 tasks
walterra
force-pushed
the
ml-transform-pipelines
branch
from
e1a2e7c
to
153cc5f
Compare
|
Pinging @elastic/ml-ui (:ml) |
| } | ||
| )} | ||
| placeholder={i18n.translate( | ||
| 'xpack.transform.stepDetailsForm.destinationIngestPipelinComboBoxPlaceholder', |
There was a problem hiding this comment.
Spotted the deliberate typo! Pipelin!
There was a problem hiding this comment.
Ha, fixed in d2250c1.
| @@ -219,6 +219,10 @@ export const getCreateTransformRequestBody = ( | |||
| : {}), | |||
| dest: { | |||
| index: transformDetailsState.destinationIndex, | |||
There was a problem hiding this comment.
Did you consider adding the pipeline to the details summary?
| label={i18n.translate( | ||
| 'xpack.transform.stepDetailsForm.destinationIngestPipelineLabel', | ||
| { | ||
| defaultMessage: 'Destination ingest pipeline', |
There was a problem hiding this comment.
As discussed, if I add a pipeline, hit Next, and then Previous, the pipeline is being forgotten. It also isn't being saved in the config.
darnautov
approved these changes
Feb 1, 2022
| @@ -46,6 +46,7 @@ import type { GetTransformsStatsResponseSchema } from '../../../common/api_schem | |||
| import { TransformId } from '../../../common/types/transform'; | |||
| import { API_BASE_PATH } from '../../../common/constants'; | |||
| import { EsIndex } from '../../../common/types/es_index'; | |||
| import { EsIngestPipeline } from '../../../common/types/es_ingest_pipeline'; | |||
There was a problem hiding this comment.
nit
Suggested change
| import { EsIngestPipeline } from '../../../common/types/es_ingest_pipeline'; | |
| import type { EsIngestPipeline } from '../../../common/types/es_ingest_pipeline'; |
| @@ -54,6 +59,26 @@ export const EditTransformFlyoutForm: FC<EditTransformFlyoutFormProps> = ({ | |||
| [indexPatternId, indexPatternsClient] | |||
| ); | |||
|
|
|||
| // fetch pipeline names once for form validation | |||
| useEffect(() => { | |||
There was a problem hiding this comment.
nit
Suggested change
| useEffect(() => { | |
| useEffect(function fetchPipelinesOnMount() { |
qn895
approved these changes
Feb 1, 2022
💚 Build SucceededMetrics [docs]Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @walterra |
|
Tested latest changes (with adding pipeline, navigating next and then previous, and cloning the transform) and LGTM. |
peteharverson
added
release_note:feature
This was referenced Feb 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of #102594.
Checklist