Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Infra] Use Kibana time zone setting for all charts #123139

Merged
merged 1 commit into from
Jan 18, 2022
Merged

[Infra] Use Kibana time zone setting for all charts #123139

merged 1 commit into from
Jan 18, 2022

Conversation

miltonhultgren
Copy link
Contributor

@miltonhultgren miltonhultgren commented Jan 17, 2022 •
edited
Loading

Closes #122683

Summary

Charts in the Metrics and Logs UI now use Kibana's time zone setting.

Testing

  1. Ingest some metrics data
  2. Set the Kibana Advanced Setting "Timezone for date formatting" to a time zone of your liking
  3. Open some page with a chart (Metrics Explorer for example) and verify that the charts display data in the chosen time zone

@miltonhultgren miltonhultgren requested a review from a team as a code owner January 17, 2022 11:20
@miltonhultgren miltonhultgren added Feature:Logs UI Logs UI feature Feature:Metrics UI Metrics UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v8.0.0 v8.1.0 labels Jan 17, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI)

@miltonhultgren miltonhultgren added release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed labels Jan 17, 2022
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
infra 922 923 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
infra 996.2KB 997.0KB +816.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@weltenwort weltenwort self-requested a review January 17, 2022 16:31
@miltonhultgren miltonhultgren removed the request for review from simianhacker January 17, 2022 16:44
weltenwort
weltenwort approved these changes Jan 17, 2022
View reviewed changes
Copy link
Member

@weltenwort weltenwort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, thank you

@miltonhultgren miltonhultgren changed the title [Infra] Use Kibana time zone setting for all charts (#122683) [Infra] Use Kibana time zone setting for all charts Jan 18, 2022
@miltonhultgren miltonhultgren merged commit cb3e0ec into elastic:main Jan 18, 2022
@kibanamachine kibanamachine mentioned this pull request Jan 18, 2022
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.0

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jan 18, 2022
@miltonhultgren @kibanamachine
[Infra] Use Kibana time zone setting for all charts (elastic#123139)
1a6f754 
(cherry picked from commit cb3e0ec)
@markov00 markov00 mentioned this pull request Jan 18, 2022
Merged
7 tasks
@miltonhultgren miltonhultgren mentioned this pull request Jan 18, 2022
Merged
miltonhultgren added a commit to miltonhultgren/kibana that referenced this pull request Jan 18, 2022
@miltonhultgren
[Infra] Use Kibana time zone setting for all charts (elastic#123139)
ca17c5f 
(cherry picked from commit cb3e0ec)
@miltonhultgren miltonhultgren mentioned this pull request Jan 18, 2022
Merged
@miltonhultgren
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
✅ 7.17
✅ 7.16

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jan 18, 2022
@kibanamachine @miltonhultgren
[Infra] Use Kibana time zone setting for all charts (#123139) (#123198)
4e14965 
(cherry picked from commit cb3e0ec)

Co-authored-by: Milton Hultgren <milton.hultgren@elastic.co>
miltonhultgren added a commit that referenced this pull request Jan 18, 2022
@miltonhultgren
[Infra] Use Kibana time zone setting for all charts (#123139) (#123203)
82052d8 
(cherry picked from commit cb3e0ec)
miltonhultgren added a commit that referenced this pull request Jan 18, 2022
@miltonhultgren
[Infra] Use Kibana time zone setting for all charts (#123139) (#123204)
e73e2e8 
(cherry picked from commit cb3e0ec)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weltenwort weltenwort weltenwort approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Logs UI Logs UI feature Feature:Metrics UI Metrics UI feature release_note:skip Skip the PR/issue when compiling release notes Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.16.0 v7.17.0 v8.0.0 v8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Metrics UI] All the times on the Elastic Charts are using UTC instead of the browser timezone
5 participants
@miltonhultgren @elasticmachine @kibana-ci @kibanamachine @weltenwort