[Security Solution] Fix signals index initialization bug #123087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephmilovic
added
v8.0.0
release_note:skip
|
Pinging @elastic/security-threat-hunting (Team:Threat Hunting) |
stephmilovic
changed the title
madirey
approved these changes
Jan 15, 2022
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
|
I have tested this as well on my local and looks fine. @stephmilovic there is just a little detail I would like to double-check with you when you have time (it is not something that should block the merge) |
semd
approved these changes
Jan 17, 2022
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jan 17, 2022
) (cherry picked from commit fef96e9)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jan 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
See here: #122958
We need to poll for the signals index between when it a rule is created and the first alert is written. Before we were doing this by polling when the user hits search as we were counting on the user hitting refresh to see their very first alerts on the Rule Details page after it was created. However, if you navigate away from the Rule Details page and back to the alerts page, the Alerts query will rerun but the poll for the signals index will not. I fixed this by polling on the Sourcerer component itself when this condition is true.
Checklist