Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ClusterClient: do no filter auth headers #122917

Merged
merged 3 commits into from
Jan 17, 2022

Conversation

pgayvallet
Copy link
Contributor

@pgayvallet pgayvallet commented Jan 13, 2022

Summary

Fix #122910

Checklist

@pgayvallet pgayvallet added Feature:elasticsearch release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.17.0 v8.0.0 v8.1.0 labels Jan 13, 2022
@pgayvallet pgayvallet marked this pull request as ready for review January 13, 2022 13:16
@pgayvallet pgayvallet requested a review from a team as a code owner January 13, 2022 13:16
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@lukeelmers lukeelmers added the bug Fixes for quality problems that affect the customer experience label Jan 14, 2022
@pgayvallet
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@pgayvallet pgayvallet added the auto-backport Deprecated - use backport:version if exact versions are needed label Jan 17, 2022
@pgayvallet pgayvallet merged commit c9543dc into elastic:main Jan 17, 2022
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jan 17, 2022
* ClusterClient: do no filter auth headers

* don't even know how this happened

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit c9543dc)
@kibanamachine
Copy link
Contributor

💔 Some backports could not be created

Status Branch Result
8.0
7.17 Backport failed because of merge conflicts

How to fix

Re-run the backport manually:

node scripts/backport --pr 122917

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

pgayvallet added a commit to pgayvallet/kibana that referenced this pull request Jan 17, 2022
* ClusterClient: do no filter auth headers

* don't even know how this happened

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit c9543dc)

# Conflicts:
#	src/core/server/elasticsearch/client/cluster_client.ts
kibanamachine added a commit that referenced this pull request Jan 17, 2022
* ClusterClient: do no filter auth headers

* don't even know how this happened

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit c9543dc)

Co-authored-by: Pierre Gayvallet <pierre.gayvallet@elastic.co>
pgayvallet added a commit that referenced this pull request Jan 18, 2022
* ClusterClient: do no filter auth headers (#122917)

* ClusterClient: do no filter auth headers

* don't even know how this happened

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit c9543dc)

# Conflicts:
#	src/core/server/elasticsearch/client/cluster_client.ts

* fix client type

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed bug Fixes for quality problems that affect the customer experience Feature:elasticsearch release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.17.0 v8.0.0 v8.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

elasticsearch.requestHeadersWhitelist should not filter headers coming from the auth hook
5 participants