Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Performance Tests for Login and Home Pages by using Playwright #119681
Performance Tests for Login and Home Pages by using Playwright #119681
Changes from 75 commits
025c0d9
ee2579a
ade404f
6eba35d
d8e7a31
a441885
3c0323b
2518fd4
2954966
e0dbfe0
67d0d6c
b15fcb5
d2bb2cc
aca36a8
93ebbc2
5704c08
f3e6cb7
f76fa49
c3f75da
0e57d0d
72481c9
f5b7dfa
0e0db3f
81aae99
716f52d
153461b
10a82e1
9e6464f
e4d7a77
4446d0d
b04a6f7
3e3f721
18dbca8
94c1cd1
b663b80
4ab0d20
89851cc
6d0c3a7
0dfba3d
0119f20
05af355
20f761c
6ca43be
93b1e64
bfe18af
1d01d23
9ab68c0
bb86c46
df73226
1e374d6
0088a34
a7d18de
635f9c2
b1c4831
40292e7
ac8960e
26746bf
96ccf63
9523fee
e4fd740
3a3c65d
ceeaf9c
24caf56
10f20bc
52e95d8
2a81b1a
ccbf85f
0bde91f
f7ec8e9
f5a443a
6d1460e
0f525ce
16032a0
4778a08
2441674
8f334a0
4470336
1730c8d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Anyone know why we removed these? I was looking for a way to throttle during a functional test to confirm a loading theory. Seems like this might have worked and I was about to add
3G_SLOW
back. But maybe I shouldn't?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We removed them because they were inaccurate and finding information that accurately describes the speeds used by the browser profiles was really hard, so we punted on it and only worried about the profile that we actually use.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gotcha. #135103 has the snippet I ended up using instead (to slow a test down enough to fail). Maybe this sort of thing would be better as a helper rather than webdriver-init-time setting 🤔
This file was deleted.
This file was deleted.