[Onweek] PBT for get_time #119157
Draft
[Onweek] PBT for get_time #119157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jloleysens
added
v8.0.0
release_note:skip
💚 Build Succeeded
Metrics [docs]To update your PR or re-run it, just comment with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of OnWeek experimentation with PBTs, this test shows how we could ensure that we are converting dates in an expected fashion. Some of this work is still WIP, the test assertions could be a bit more precise, but at least this code is being run with a much larger set of inputs.
Notes
Currently all implementation for the test lives in one file for convenience. There is clearly a use case for making arbitraries re-usable across tests but this was not done for brevity.