Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default kibana.yml #117597

Merged

Conversation

TinaHeiligers
Copy link
Contributor

@TinaHeiligers TinaHeiligers commented Nov 4, 2021

Summary

Resolves #116296

With a new major release, we needed to audit the default kibana.yml template to ensure any deprecated settings have been updated and/or removed. Fortunately, the configurations already provided are all still valid and up to date but could be rearranged into logical groupings to make it easier to read.

This PR enhances the config template:

  • Regroups configurations into general categories to improve readability (with a heading for each).
  • Adds a link to elastic docs with a comment on where to find more config options. Since our docs are versioned, I chose to give a link that doesn't reference a branch in particular and rather added a comment about what someone would look for.
  • Adds important and frequently used configurations for non-subscription level features, inspired by the configurations we use within a stackpack and those allow-listed in cloud.
  • Fixes minor typo's and language

@TinaHeiligers TinaHeiligers added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc release_note:skip Skip the PR/issue when compiling release notes Feature:Configuration Settings in kibana.yml v8.1.0 labels Nov 4, 2021
@TinaHeiligers TinaHeiligers marked this pull request as ready for review November 4, 2021 21:53
@TinaHeiligers TinaHeiligers requested a review from a team as a code owner November 4, 2021 21:53
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream


# Set the value of this setting to off to suppress all logging output, or to debug to log everything.
# =================== System: Logging ===================
# Set the value of this setting to off to suppress all logging output, or to debug to log everything. Defaults to 'error'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Set the value of this setting to off to suppress all logging output, or to debug to log everything. Defaults to 'error'
# Set the value of this setting to off to suppress all logging output, or to debug to log everything. Defaults to 'info'

# The number of documents migrated at a time.
# If Kibana can't start up or upgrade due to an Elasticsearch `circuit_breaking_exception`,
# use a smaller batchSize value to reduce the memory pressure. Defaults to 1000
# migrations.batchSize: 1000
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# migrations.batchSize: 1000
#migrations.batchSize: 1000

# To avoid migrations failing due to a 413 Request Entity Too Large response from Elasticsearch.
# This value should be lower than or equal to your Elasticsearch cluster’s `http.max_content_length`
# configuration option. Default: 100mb
# migrations.maxBatchSizeBytes: 100mb
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# migrations.maxBatchSizeBytes: 100mb
#migrations.maxBatchSizeBytes: 100mb

# The number of times to retry temporary migration failures. Increase the setting
# if migrations fail frequently with a message such as `Unable to complete the [...] step after
# 15 attempts, terminating`. Defaults to 15
# migrations.retryAttempts: 15
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# migrations.retryAttempts: 15
#migrations.retryAttempts: 15

# =================== Search Autocomplete ===================
# Time in milliseconds to wait for autocomplete suggestions from Elasticsearch.
# This value must be a whole number greater than zero. Defaults to 1000
# data.autocomplete.valueSuggestions.timeout: 1000
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# data.autocomplete.valueSuggestions.timeout: 1000
#data.autocomplete.valueSuggestions.timeout: 1000


# Maximum number of documents loaded by each shard to generate autocomplete suggestions.
# This value must be a whole number greater than zero. Defaults to 100000
# data.autocomplete.valueSuggestions.terminateAfter: 100000
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# data.autocomplete.valueSuggestions.terminateAfter: 100000
#data.autocomplete.valueSuggestions.terminateAfter: 100000


# Specifies the path where Kibana creates the process ID file.
#pid.file: /run/kibana/kibana.pid

# Set the interval in milliseconds to sample system and process performance
# metrics. Minimum is 100ms. Defaults to 5000.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# metrics. Minimum is 100ms. Defaults to 5000.
# metrics. Minimum is 100ms. Defaults to 5000ms.


# The number of documents migrated at a time.
# If Kibana can't start up or upgrade due to an Elasticsearch `circuit_breaking_exception`,
# use a smaller batchSize value to reduce the memory pressure. Defaults to 1000
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# use a smaller batchSize value to reduce the memory pressure. Defaults to 1000
# use a smaller batchSize value to reduce the memory pressure. Defaults to 1000 objects per batch.


# =================== Search Autocomplete ===================
# Time in milliseconds to wait for autocomplete suggestions from Elasticsearch.
# This value must be a whole number greater than zero. Defaults to 1000
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# This value must be a whole number greater than zero. Defaults to 1000
# This value must be a whole number greater than zero. Defaults to 1000ms

# data.autocomplete.valueSuggestions.timeout: 1000

# Maximum number of documents loaded by each shard to generate autocomplete suggestions.
# This value must be a whole number greater than zero. Defaults to 100000
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# This value must be a whole number greater than zero. Defaults to 100000
# This value must be a whole number greater than zero. Defaults to 100_000

@TinaHeiligers TinaHeiligers merged commit ff7e77a into elastic:main Nov 5, 2021
TinaHeiligers added a commit that referenced this pull request Nov 5, 2021
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Nov 9, 2021
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 117597 or prevent reminders by adding the backport:skip label.

4 similar comments
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 117597 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 117597 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 117597 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 117597 or prevent reminders by adding the backport:skip label.

@TinaHeiligers TinaHeiligers added v8.0.0 auto-backport Deprecated - use backport:version if exact versions are needed and removed backport missing Added to PRs automatically when the are determined to be missing a backport. labels Nov 15, 2021
TinaHeiligers added a commit to TinaHeiligers/kibana that referenced this pull request Nov 15, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 15, 2021
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
8.0

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Nov 15, 2021
Co-authored-by: Christiane (Tina) Heiligers <christiane.heiligers@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Configuration Settings in kibana.yml release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v8.0.0 v8.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update default kibana.yml in 8.0
5 participants