[Uptime] Added uptime query inspector panel #115170

shahzad31 · 2021-10-15T11:44:20Z

Summary

Fix #112655

and also added a UI based inspector panel, which can be turned on from

Advanced Settings > Observability > Inspect ES queries

Testing

Check inspector panels shows relavant query info for each page
Test etc pass

This doesn't change core functionality.

PR only covers happy paths for now, in a follow up, it will make sense to handle query error states.

elasticmachine · 2021-10-15T11:46:19Z

Pinging @elastic/uptime (Team:uptime)

elasticmachine · 2021-10-15T11:55:08Z

Pinging @elastic/apm-ui (Team:apm)

sorenlouv

apm changes lgtm

justinkambic

LGTM!

x-pack/plugins/uptime/public/components/common/header/inspector_header_link.tsx

…tor-panel

kibanamachine · 2021-10-16T11:57:09Z

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`observability`	375	376	+1
`uptime`	663	664	+1
total			+2

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`observability`	260	265	+5

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`observability`	378.9KB	379.1KB	+191.0B
`uptime`	570.0KB	571.0KB	+1.0KB
total			+1.2KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id	before	after	diff
`observability`	13	15	+2

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`observability`	34.8KB	38.1KB	+3.3KB

Unknown metric groups

API count

id	before	after	diff
`observability`	261	266	+5

History

💔 Build #161630 failed dace0d3
💚 Build #161456 succeeded b84efec
💔 Build #161363 failed 38390e3
💔 Build #161358 failed d265732

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @shahzad31

kibanamachine · 2021-10-18T08:38:35Z

💔 Backport failed

Status	Branch	Result
❌	7.x	Commit could not be cherrypicked due to conflicts

To backport manually run:
node scripts/backport --pr 115170

…-migrate-away-from-injected-css-js * 'master' of github.com:elastic/kibana: (237 commits) [Uptime] Added uptime query inspector panel (elastic#115170) [Osquery] Add packs (elastic#107345) [App Search] Allow for query parameter to indicate ingestion mechanism for new engines (elastic#115188) [Alerting] Active alerts do not recover after re-enabling a rule (elastic#111671) skip flaky tests. elastic#115308, elastic#115313 [Breaking] Remove deprecated `enabled` settings from plugins. (elastic#113495) skip flaky suite. elastic#107057 skip flaky tests. elastic#89052, elastic#113418, elastic#115304 skip flaky test. elastic#113892 Bump node to 16.11.1 (elastic#110684) [Security Solution] Restores Alerts table local storage persistence and the Remove Column action (elastic#114742) skip flaky suite. elastic#115130 one line remove assert (elastic#115127) Fixes migration bug where I was deleting attributes (elastic#115098) [Security Solutions] Fixes the newer notification system throttle resets and enabling immediate execution on first detection of a signal (elastic#114214) [build] Dockerfile update (elastic#115237) Fixes Cypress flake cypress test (elastic#115270) Disable APM e2e tests log an invalid type for SO (elastic#115175) [Fleet] Don't auto upgrade policies for AUTO_UPDATE packages (elastic#115199) ... # Conflicts: # src/plugins/dashboard/public/application/dashboard_app.tsx # src/plugins/dashboard/public/types.ts # x-pack/plugins/reporting/server/lib/layouts/print_layout.ts

…-link-to-kibana-app * 'master' of github.com:elastic/kibana: (287 commits) [Security Solution][Endpoint] Change `trustedAppByPolicyEnabled` flag to `true` by default (elastic#115264) [APM] generator: support error events and application metrics (elastic#115311) [kibanaUtils] Don't import full `semver` client side (elastic#114986) [RAC] Link inventory alerts to the right inventory view (elastic#113553) [Uptime] Added uptime query inspector panel (elastic#115170) [Osquery] Add packs (elastic#107345) [App Search] Allow for query parameter to indicate ingestion mechanism for new engines (elastic#115188) [Alerting] Active alerts do not recover after re-enabling a rule (elastic#111671) skip flaky tests. elastic#115308, elastic#115313 [Breaking] Remove deprecated `enabled` settings from plugins. (elastic#113495) skip flaky suite. elastic#107057 skip flaky tests. elastic#89052, elastic#113418, elastic#115304 skip flaky test. elastic#113892 Bump node to 16.11.1 (elastic#110684) [Security Solution] Restores Alerts table local storage persistence and the Remove Column action (elastic#114742) skip flaky suite. elastic#115130 one line remove assert (elastic#115127) Fixes migration bug where I was deleting attributes (elastic#115098) [Security Solutions] Fixes the newer notification system throttle resets and enabling immediate execution on first detection of a signal (elastic#114214) [build] Dockerfile update (elastic#115237) ... # Conflicts: # x-pack/plugins/reporting/public/management/__snapshots__/report_listing.test.tsx.snap

sorenlouv · 2022-11-17T16:23:46Z

x-pack/plugins/observability/public/context/inspector/inspector_context.tsx

@@ -23,6 +23,13 @@ const value: InspectorContextValue = {

 export const InspectorContext = createContext<InspectorContextValue>(value);

+export type AddInspectorRequest = (
+  result: FetcherResult<{
+    mainStatisticsData?: { _inspect?: InspectResponse };


@shahzad31 Do you remember why you added mainStatisticsData? Seems like something from APM that was copied in accidentally?

Added uptime query inspector panel

d265732

shahzad31 self-assigned this Oct 15, 2021

shahzad31 marked this pull request as ready for review October 15, 2021 11:45

shahzad31 requested review from a team as code owners October 15, 2021 11:45

shahzad31 added v7.16.0 v8.0.0 release_note:enhancement Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability labels Oct 15, 2021

removed unused exception

38390e3

botelastic bot added the Team:APM All issues that need APM UI Team support label Oct 15, 2021

sorenlouv approved these changes Oct 15, 2021

View reviewed changes

shahzad31 added 2 commits October 15, 2021 15:54

fix types

4fd1180

fix test

b84efec

justinkambic approved these changes Oct 15, 2021

View reviewed changes

x-pack/plugins/uptime/public/components/common/header/inspector_header_link.tsx Outdated Show resolved Hide resolved

shahzad31 added 2 commits October 15, 2021 21:04

Merge branch 'master' of github.com:elastic/kibana into uptime-inspec…

5ab2cd5

…tor-panel

fix conflicts

dace0d3

smith mentioned this pull request Oct 15, 2021

[APM] e2e test failing #115280

Closed

shahzad31 added 2 commits October 16, 2021 11:52

PR feedback

c3cd573

Merge branch 'master' of github.com:elastic/kibana into uptime-inspec…

ff20003

…tor-panel

shahzad31 merged commit d08f091 into elastic:master Oct 18, 2021

shahzad31 deleted the uptime-inspector-panel branch October 18, 2021 08:35

shahzad31 added the auto-backport Deprecated - use backport:version if exact versions are needed label Oct 18, 2021

shahzad31 added a commit to shahzad31/kibana that referenced this pull request Oct 18, 2021

[Uptime] Added uptime query inspector panel (elastic#115170)

93628e2

shahzad31 mentioned this pull request Oct 18, 2021

[7.x] [Uptime] Added uptime query inspector panel (#115170) #115376

Merged

shahzad31 added a commit that referenced this pull request Oct 18, 2021

[Uptime] Added uptime query inspector panel (#115170) (#115376)

a6e9d8f

artem-shelkovnikov pushed a commit to artem-shelkovnikov/kibana that referenced this pull request Oct 20, 2021

[Uptime] Added uptime query inspector panel (elastic#115170)

71ca5ef

sorenlouv reviewed Nov 17, 2022

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Uptime] Added uptime query inspector panel #115170

[Uptime] Added uptime query inspector panel #115170

shahzad31 commented Oct 15, 2021 •

edited

Loading

elasticmachine commented Oct 15, 2021

elasticmachine commented Oct 15, 2021

sorenlouv left a comment

justinkambic left a comment

kibanamachine commented Oct 16, 2021

API count

kibanamachine commented Oct 18, 2021

sorenlouv Nov 17, 2022

[Uptime] Added uptime query inspector panel #115170

[Uptime] Added uptime query inspector panel #115170

Conversation

shahzad31 commented Oct 15, 2021 • edited Loading

Summary

Testing

elasticmachine commented Oct 15, 2021

elasticmachine commented Oct 15, 2021

sorenlouv left a comment

Choose a reason for hiding this comment

justinkambic left a comment

Choose a reason for hiding this comment

kibanamachine commented Oct 16, 2021

💚 Build Succeeded

Metrics [docs]

Module Count

Public APIs missing comments

Async chunks

Public APIs missing exports

Page load bundle

API count

History

kibanamachine commented Oct 18, 2021

💔 Backport failed

sorenlouv Nov 17, 2022

Choose a reason for hiding this comment

shahzad31 commented Oct 15, 2021 •

edited

Loading