Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] [Sourcerer] Timeline Reset button, bug fix #115113

Merged
merged 2 commits into from
Oct 15, 2021
Merged

[Security Solution] [Sourcerer] Timeline Reset button, bug fix #115113

merged 2 commits into from
Oct 15, 2021

Conversation

stephmilovic
Copy link
Contributor

Fixes the timeline sourcerer bug in #98466 as well as another bug with timeline sourcerer options. Both of these bugs were on the pick_events component

This fix does not need to go into v8.0.0 as #114805 removes the pick_events component

Bug 1

Steps: Make changes to the timeline sourcerer from the "All data sources" default. Press save. Open and press "Reset" button.

Before: Observe UI does not reset to the "All data sources" default

bug1

After: Observe UI does reset to the "All data sources" default

fix1

Bug 1

Steps: Create a Kibana index pattern like auditbeat-*,.siem-signals-default. Open timeline sourcerer. Close box option for .siem-signals-default

Before: Observe sourcerer options do not update to include .siem-signals-default

bug2

After: Observe sourcerer options update to include .siem-signals-default

fix2

Checklist

@stephmilovic stephmilovic added bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed v7.16.0 labels Oct 14, 2021
@stephmilovic stephmilovic requested a review from a team as a code owner October 14, 2021 22:38
@stephmilovic stephmilovic requested a review from a team October 14, 2021 22:38
@stephmilovic stephmilovic added Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting Security Solution Threat Hunting Team Team:Threat Hunting:Explore labels Oct 14, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@stephmilovic stephmilovic mentioned this pull request Oct 14, 2021
Closed
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 4.6MB 4.6MB -46.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

angorayc
angorayc approved these changes Oct 15, 2021
View reviewed changes
Copy link
Contributor

@angorayc angorayc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you fox fixing this @stephmilovic, tested locally, all looked good!

@stephmilovic stephmilovic merged commit a0c5c11 into elastic:master Oct 15, 2021
@stephmilovic stephmilovic mentioned this pull request Oct 15, 2021
Closed
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 15, 2021
@stephmilovic @kibanamachine
[Security Solution] [Sourcerer] Timeline Reset button, bug fix (elast…
0d0cf5a 
…ic#115113)
@kibanamachine kibanamachine mentioned this pull request Oct 15, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

stephmilovic added a commit to stephmilovic/kibana that referenced this pull request Oct 15, 2021
@stephmilovic
[Security Solution] [Sourcerer] Timeline Reset button, bug fix (elast…
7a3dba5 
…ic#115113)
kibanamachine added a commit that referenced this pull request Oct 16, 2021
@kibanamachine @stephmilovic
[Security Solution] [Sourcerer] Timeline Reset button, bug fix (#115113…
4ebb518 
…) (#115203)

Co-authored-by: Steph Milovic <stephanie.milovic@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angorayc angorayc angorayc approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Explore Team:Threat Hunting Security Solution Threat Hunting Team v7.16.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stephmilovic @elasticmachine @kibanamachine @angorayc