Skip to content

Conversation

@tylersmalley
Copy link
Contributor

@tylersmalley tylersmalley commented Oct 13, 2021

After #114035, we are no longer writing Bazel cache to Buildkite.

We were specifying an API key in the general .bazelrc file, and setup_bazel.sh is attempting to overwrite that value. However, that doesn't work like other options and we end up with a read-only API key.

Writing the .bazelrc to the home directory was confusing. Instead, we're just overwriting the file on CI when we intend to write to the cache.

image

@tylersmalley tylersmalley force-pushed the bazel-write-on-merge branch 6 times, most recently from 2021789 to af3e058 Compare October 13, 2021 22:40
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
@tylersmalley tylersmalley changed the title [ci] Explicitly enable writing Bazel cache [ci] Fixes Bazel cache writes Oct 13, 2021
@tylersmalley tylersmalley added Team:Operations Kibana-Operations Team v7.16.0 v8.0.0 auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes labels Oct 13, 2021
@tylersmalley tylersmalley marked this pull request as ready for review October 13, 2021 23:06
@tylersmalley tylersmalley requested a review from a team as a code owner October 13, 2021 23:06
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
@tylersmalley
Copy link
Contributor Author

Pushed to upstream to kick off a test here: https://buildkite.com/elastic/kibana-on-merge/builds/5487#f85278dc-065e-419c-9848-19a8b1cd0965 and validate the build invocation on Buildbuddy. Included the screenshot in the description showing it's now uploading.

@brianseeders
Copy link
Contributor

Where is the public key getting added? Maybe I'm just not seeing it because I'm on my phone, but I don't see it

@brianseeders
Copy link
Contributor

Never mind, I see, my bad!

@tylersmalley tylersmalley enabled auto-merge (squash) October 14, 2021 00:18
@tylersmalley tylersmalley merged commit 5647de3 into elastic:master Oct 14, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 14, 2021
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Oct 14, 2021
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>

Co-authored-by: Tyler Smalley <tyler.smalley@elastic.co>
jloleysens added a commit to jloleysens/kibana that referenced this pull request Oct 14, 2021
…mple/introduce-baseline-tests

* 'master' of github.com:elastic/kibana: (55 commits)
  [Fleet] Improve Functionality around Managed Package Policies (elastic#114526)
  cleanup (elastic#114902)
  remove stray semicolon (elastic#114969)
  [Security Solution] Edit host isolation exception IP UI (elastic#114279)
  [ML] APM Correlations: Round duration values to be used in range aggregations. (elastic#114833)
  [Index Management] Added `data-test-subj` values to the index context menu buttons (elastic#114900)
  [Stack monitoring] Fix logstash functional tests for react (elastic#114819)
  Implement hybrid approach to writing rule execution event logs (elastic#114852)
  [Detection Rules] Add 7.16 rules (elastic#114939)
  Fixing exceptions export format (elastic#114920)
  Clean up inaccurate comments (elastic#114935)
  chore(NA): fixes a typo on persist_bazel_cache.sh comment (elastic#114943)
  [ci] Fixes Bazel cache writes (elastic#114915)
  fix package.json: (elastic#114936)
  [Controls] Redux Toolkit and Embeddable Redux Wrapper (elastic#114371)
  [APM] Fixes incorrect index config names (elastic#114901) (elastic#114904)
  [Workplace Search] Fix button order and remove extra source name label (elastic#114899)
  [Actions] Fixed actions telemetry for multiple namespaces usage (elastic#114748)
  docs: fix config names (elastic#114903)
  Update kibana to EMS 7.16 (elastic#114865)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Deprecated - use backport:version if exact versions are needed buildkite-ci release_note:skip Skip the PR/issue when compiling release notes Team:Operations Kibana-Operations Team v7.16.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants