[Fleet] Stop loading js-yaml in main plugin bundle #111169
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
joshdover
force-pushed
the
fix-fleet-bundle
branch
from
1f81dfb to
dc4147c
Compare
joshdover
added
release_note:skip
joshdover
added
auto-backport
Contributor
|
Pinging @elastic/fleet (Team:Fleet) |
Contributor
💚 Build SucceededMetrics [docs]Public APIs missing comments
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
jbudz
approved these changes
Sep 6, 2021
Contributor
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
kibanamachine
added a commit
that referenced
this pull request
Sep 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related to #95863
Removes the imports for
js-yamlinx-pack/plugins/fleet/commonto avoid loading this heavy library on page load and wait until it's actually needed. In the future we may want to consider using a smaller library or moving this logic to the server-side (in a secure fashion).cc @hop-dev I know you were interested in this area. There's still a lot of room for additional improvement to get under 100kb, this was just the biggest chunk of low hanging fruit and was blocking my progress on #111131