[Cases] Do not show status dropdown on modal cases selector

[cnasikas]

Summary

When a user tries to attach an alert to a case the cases modal selector appears. In the modal, the user can see the status dropdown and try to change the status instead of selecting the case. This PR fixes this issue by hiding the status dropdown from the modal.

Ref: #110931

Checklist

Delete any items that are not applicable to this PR.

• Unit or functional tests were updated or added to match the most common scenarios
• This was checked for cross-browser compatibility

For maintainers

• This was checked for breaking API changes and was labeled appropriately

[elasticmachine]

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

[semd]

Question: Is this waitFor waiting for the dropdown not to be there? If the modal is not open yet when it is tested, won't it pass the test anyway? I am not sure, but if it's the case, maybe we could "waitFor" the modal to exist, and then test that the dropdown is not there.

[cnasikas]

@semd The waitFor is to wait for the hooks of the component. If I do not put it within the waitFor then I get the following warning:

 Warning: An update to CasesTableFiltersComponent inside a test was not wrapped in act(...).

    When testing, code that causes React state updates should be wrapped into act(...):

    act(() => {
      /* fire events that update state */
    });
    /* assert on the output */

    This ensures that you're testing the behavior the user would see in the browser. Learn more at https://fb.me/react-wrap-tests-with-act
        in CasesTableFiltersComponent
        in span
        in Unknown
        in OwnerProvider (created by TestProvidersComponent)
        in ThemeProvider (created by TestProvidersComponent)
        in Provider
        in Unknown (created by TestProvidersComponent)
        in PseudoLocaleWrapper (created by I18nProvider)
        in IntlProvider (created by I18nProvider)
        in I18nProvider (created by TestProvidersComponent)
        in TestProvidersComponent (created by WrapperComponent)
        in WrapperComponent

If the modal is not open yet when it is tested, won't it pass the test anyway? I am not sure, but if it's the case, maybe we could "waitFor" the modal to exist, and then test that the dropdown is not there.

The component that we test is not modal. It is put into a body of a modal by another component. In this component, if you pass the isSelectorView prop you tell the component that it will be used to select cases not to show them. You are right that we should wait for the component to be ready and then check the existence of the dropdown. I changed it accordingly. Thanks!

[semd]

Tested locally, the status dropdown does not appear anymore in the "Add to existing case" alert action modal.
LGTM 🚀

[kibanamachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: 0ee5ed9
• Storybooks Preview

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
cases	711.3KB	711.4KB	+54.0B

History

• 💚 Build #150866 succeeded 4eefc0a

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @cnasikas