Skip to content

Conversation

@lcawl
Copy link
Contributor

@lcawl lcawl commented Sep 3, 2021

Summary

Relates to #88107

This PR replaces hard-coded links in the uptime app with the use of the documentation link service, which is easier to maintain and is checked by the doc build.

@lcawl lcawl added enhancement New value added to drive a business result release_note:skip Skip the PR/issue when compiling release notes Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.16.0 v8.0.0 Team:Docs labels Sep 3, 2021
@lcawl lcawl marked this pull request as ready for review September 3, 2021 16:11
@lcawl lcawl requested review from a team as code owners September 3, 2021 16:11
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-docs (Team:Docs)

@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

Copy link
Contributor

@justinkambic justinkambic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lcawl
Copy link
Contributor Author

lcawl commented Sep 8, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

merge conflict between base and head

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
uptime 1.0MB 1.0MB -108.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 419.8KB 420.2KB +434.0B
uptime 36.8KB 36.6KB -189.0B
total +245.0B

History

  • 💚 Build #150797 succeeded 354a158c277d69d53e62c67381c98c5cd7f73ed5

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New value added to drive a business result release_note:skip Skip the PR/issue when compiling release notes Team:Docs Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.14.2 v7.15.1 v7.16.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants