[APM] Uses doc link service instead of ElasticDocsLink for linking metadata #110992
Conversation
szabosteve
added
v8.0.0
release_note:skip
|
Pinging @elastic/apm-ui (Team:apm) |
| const KIBANA_DOCS = `${ELASTIC_WEBSITE_URL}guide/en/kibana/${DOC_LINK_VERSION}/`; | ||
| const FLEET_DOCS = `${ELASTIC_WEBSITE_URL}guide/en/fleet/${DOC_LINK_VERSION}/`; | ||
| const PLUGIN_DOCS = `${ELASTIC_WEBSITE_URL}guide/en/elasticsearch/plugins/${DOC_LINK_VERSION}/`; | ||
| const APM_GET_STARTED_DOCS = `${ELASTIC_WEBSITE_URL}guide/en/apm/get-started/${DOC_LINK_VERSION}/`; |
There was a problem hiding this comment.
const APM_GET_STARTED_DOCS =
${ELASTIC_WEBSITE_URL}guide/en/apm/get-started/${DOC_LINK_VERSION}/;
Note that for this new constant to be checked properly, you'll also need to add it to the build_docs.pl as I did for the KIBANA_DOCS one here: elastic/docs#2132
If we end up needing links to the APM Server or APM agents books too, we might reconsider only having a single APM constant that is just ${ELASTIC_WEBSITE_URL}guide/en/apm/
There was a problem hiding this comment.
@lcawl Thanks for the info, I changed the constant and opened elastic/docs#2209 to add the check for the new constant.
lcawl
left a comment
lcawl
left a comment
There was a problem hiding this comment.
One comment, otherwise LGTM
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
6 participants
Summary
Related to #88107
This PR replaces the need for https://github.com/elastic/kibana/blob/master/x-pack/plugins/apm/public/components/shared/Links/ElasticDocsLink.tsx in the index file of the Metadata Table in the APM app. Instead, it uses the https://github.com/elastic/kibana/blob/master/src/core/public/doc_links/doc_links_service.ts, which is checked as part of the documentation builds.