-
Notifications
You must be signed in to change notification settings - Fork 8.5k
[ML] Fix Anomaly Explorer data points not showing up when index pattern has multiple indices #110899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Pinging @elastic/ml-ui (:ml) |
darnautov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
walterra
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and Code LGTM
peteharverson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested against the job in the APM module, and a population job against the traces-apm*,logs-apm*,metrics-apm*,apm-* pattern, and LGTM.
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
…ices (elastic#110899) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
…ices (elastic#110899) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
…ices (elastic#110899) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
💔 Build Failed
Failed CI Steps
Test FailuresKibana Pipeline / general / Chrome UI Functional Tests.test/functional/apps/management/_scripted_fields_filter·js.management filter scripted fields "before all" hook for "should filter scripted fields"Standard OutStack TraceKibana Pipeline / general / Chrome UI Functional Tests.test/functional/apps/dashboard/panel_context_menu·ts.dashboard app using legacy data dashboard panel context menu "before all" hook for "are hidden in view mode"Standard OutStack TraceKibana Pipeline / general / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/ml/anomaly_detection/saved_search_job·ts.machine learning anomaly detection saved search with lucene query job creation runs the job and displays it correctly in the job listStandard OutStack Traceand 4 more failures, only showing the first 3. Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @qn895 |
Summary
This PR fixes an issue in the Anomaly explorer view where the charts show up as empty, which was introduced in #94396. This happens if the job is defined using multiple indices, and currently we use only the first index to search for data points within the time range. Thus, if the data points happen to be in the other indices, the chart will end up as blank. Steps to reproduce:
apm-7.11*,apm-7.12*, apm-*error*)Expected behavior:
The chart should show up correctly with all the data points
Before
After
Checklist
Risk Matrix
Delete this section if it is not applicable to this PR.
Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.
When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:
For maintainers