[App Search] Support the warning state for crawler validation steps #110864
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
byronhulcher
added
Feature:Plugins
release_note:skip
orhantoy
reviewed
Sep 2, 2021
Contributor
orhantoy
left a comment
orhantoy
left a comment
There was a problem hiding this comment.
Looks good 💪 Just found a few minor things.
| expect(wrapper.find(EuiIcon).prop('color')).toEqual('success'); | ||
| }); | ||
|
|
||
| it('shows an alert icon when invalid', () => { |
Contributor
There was a problem hiding this comment.
Should this have been
Suggested change
| it('shows an alert icon when invalid', () => { | |
| it('shows a warning icon when invalid', () => { |
?
...c/applications/app_search/components/crawler/components/add_domain/validation_state_icon.tsx
Show resolved
Hide resolved
| }); | ||
| it('does not display the passed error message or action when state is not invalid', () => { | ||
|
|
||
| it('displays the passed error message and action is warning', () => { |
Contributor
There was a problem hiding this comment.
Should this have been
Suggested change
| it('displays the passed error message and action is warning', () => { | |
| it('displays the passed error message and action when state is warning', () => { |
?
| const wrapper = shallow( | ||
| <ValidationStepPanel | ||
| step={{ state: 'warning', message: errorMessage }} | ||
| label={'initialValidation'} |
Contributor
There was a problem hiding this comment.
Couldn't we assign directly here like
Suggested change
| label={'initialValidation'} | |
| label='initialValidation' |
?
Contributor
Author
|
Thanks for the review @orhantoy sorry this was a little sloppy. |
Contributor
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 2, 2021
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 2, 2021
Contributor
kibanamachine
added a commit
that referenced
this pull request
Sep 2, 2021
Contributor
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
kibanamachine
added
backport missing
kibanamachine
added a commit
that referenced
this pull request
Sep 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This mirrors work already done in the standalone UI.
Checklist