-
Notifications
You must be signed in to change notification settings - Fork 8.5k
[App Search] Split CrawlerLogic from CrawlerOverviewLogic #110850
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
💚 Build SucceededMetrics [docs]Module Count
Async chunks
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not a Kea expert but the changes look pretty safe to me.
I was wondering why deleteDomain also wasn't moved so we could drop that logic file completely?
|
@orhantoy Could you approve? Jason is on PTO until Monday and I'd like to get this into the next 7.15 BC ASAP
Since that logic is specific to the CrawlerOverview page, I wanted to keep it there. The CrawlerSingleDomain page has its own deleteDomain action, it didn't make sense to me to have one higher than the other in the hierarchy. |
orhantoy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since that logic is specific to the CrawlerOverview page, I wanted to keep it there. The CrawlerSingleDomain page has its own deleteDomain action, it didn't make sense to me to have one higher than the other in the hierarchy.
Makes sense; thanks for the explanation 💯
Summary
This moves 99% functionality from out of the logic powering the
CrawlerOverviewview out into a more general logic for all Crawler views, includingCrawlerSingleDomain. All thats left inCrawlerOverviewLogicis thedeleteDomainaction. The rest has been migrated verbatim to the newCrawlerLogic. I've also updated related Crawler components to use the correct logic.In the near future (following this PR) I'm going to do a big re-org of the crawler directory, to make clearer what components are shared or unique to each crawler view.
Checklist