Skip to content

Conversation

@byronhulcher
Copy link
Contributor

@byronhulcher byronhulcher commented Sep 1, 2021

Summary

This moves 99% functionality from out of the logic powering the CrawlerOverview view out into a more general logic for all Crawler views, including CrawlerSingleDomain. All thats left in CrawlerOverviewLogic is the deleteDomain action. The rest has been migrated verbatim to the new CrawlerLogic. I've also updated related Crawler components to use the correct logic.

In the near future (following this PR) I'm going to do a big re-org of the crawler directory, to make clearer what components are shared or unique to each crawler view.

Checklist

@byronhulcher byronhulcher added Feature:Plugins release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed v7.15.0 v7.16.0 v7.15.1 labels Sep 1, 2021
@byronhulcher byronhulcher self-assigned this Sep 1, 2021
@byronhulcher byronhulcher requested a review from a team September 1, 2021 17:19
@byronhulcher byronhulcher enabled auto-merge (squash) September 1, 2021 17:19
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
enterpriseSearch 1472 1473 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 2.2MB 2.2MB +140.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @byronhulcher

Copy link
Contributor

@orhantoy orhantoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a Kea expert but the changes look pretty safe to me.

I was wondering why deleteDomain also wasn't moved so we could drop that logic file completely?

@byronhulcher
Copy link
Contributor Author

@orhantoy Could you approve? Jason is on PTO until Monday and I'd like to get this into the next 7.15 BC ASAP

I was wondering why deleteDomain also wasn't moved so we could drop that logic file completely?

Since that logic is specific to the CrawlerOverview page, I wanted to keep it there. The CrawlerSingleDomain page has its own deleteDomain action, it didn't make sense to me to have one higher than the other in the hierarchy.

Copy link
Contributor

@orhantoy orhantoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since that logic is specific to the CrawlerOverview page, I wanted to keep it there. The CrawlerSingleDomain page has its own deleteDomain action, it didn't make sense to me to have one higher than the other in the hierarchy.

Makes sense; thanks for the explanation 💯

@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
7.15
7.x

The backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Sep 2, 2021
Co-authored-by: Byron Hulcher <byronhulcher@gmail.com>
kibanamachine added a commit that referenced this pull request Sep 2, 2021
Co-authored-by: Byron Hulcher <byronhulcher@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Deprecated - use backport:version if exact versions are needed Feature:Plugins release_note:skip Skip the PR/issue when compiling release notes v7.15.0 v7.15.1 v7.16.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants