[Security Solution] - remove alerts subfeature UI from behind feature flag #108450
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yctercero
added
v8.0.0
release_note:skip
Contributor
|
Pinging @elastic/security-detections-response (Team:Detections and Resp) |
Contributor
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
yctercero
added
the
auto-backport
Contributor
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: cc @yctercero |
jportner
reviewed
Aug 13, 2021
| const ruleTypes = [ | ||
| SIGNALS_ID, | ||
| NOTIFICATIONS_ID, | ||
| ...(isRuleRegistryEnabled ? racRuleTypes : []), |
Contributor
There was a problem hiding this comment.
Based on this remaining conditional on isRuleRegistryEnabled, even if the sub-feature privilege is shown, RAC rule types will not be included unless the feature flag is enabled.
Is this expected?
Contributor
Author
There was a problem hiding this comment.
Yes! That's expected. For 7.15 we are not shipping with rule registry rules.
jportner
approved these changes
Aug 14, 2021
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Aug 14, 2021
… flag (elastic#108450) ### Summary This removes the feature flag check for showing the alerts subfeature under security solution Kibana roles UI.
Contributor
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This removes the feature flag check for showing the alerts subfeature under security solution Kibana roles UI.