[data][bfetch] Avoid using Buffer in client code
#107278
Conversation
| */ | ||
|
|
||
| import { unzlibSync, strFromU8 } from 'fflate'; | ||
| import { toByteArray } from 'base64-js'; |
There was a problem hiding this comment.
This is an existing dependency and it's a dependency of Buffer polyfill. So using it directly here doesn't make it worse. It costs less than the whole Buffer
| * Side Public License, v 1. | ||
| */ | ||
|
|
||
| import escape from 'lodash/escape'; |
There was a problem hiding this comment.
Fixing wrong import. Should be better now, because lodash is included in shared deps
| return Buffer.from(val, 'base64').toString('utf8'); | ||
| if (window && window.atob) return window.atob(val); | ||
| // referencing from `global` tricks webpack to not include `Buffer` polyfill into this bundle | ||
| return global.Buffer.from(val, 'base64').toString('utf8'); |
There was a problem hiding this comment.
This seems to be tricking webpack to not bundle a polyfill for Buffer
|
@elasticmachine merge upstream |
Dosant
changed the title
Buffer in client code
Dosant
added
release_note:skip
|
Pinging @elastic/kibana-app-services (Team:AppServices) |
lizozom
left a comment
lizozom
left a comment
There was a problem hiding this comment.
Beautiful changes. Thank you!
botelastic
bot
added
the
Feature:ExpressionLanguage
…a-bundle # Conflicts: # packages/kbn-optimizer/limits.yml
💚 Build SucceededMetrics [docs]Module Count
Page load bundle
History
To update your PR or re-run it, just comment with: |
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
Co-authored-by: Anton Dosov <anton.dosov@elastic.co>
5 participants
Summary
Partially addresses #107280:
Do not use
Bufferin client-sidedataandbfetchcode to reduce bundle sizeAlso, fix a single
lodashimport indataAlternatively, this
Bufferpolyfill should be shared across bundles since it is anyway used incore