[Discover] Improve functional testing searchOnPageLoad #107181
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kertal
added
Feature:Discover
kertal
changed the title
kertal
added
v7.14.1
v7.15.0
v8.0.0
release_note:skip
Contributor
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
Member
Author
|
@elasticmachine merge upstream |
majagrubic
approved these changes
Aug 2, 2021
Contributor
majagrubic
left a comment
majagrubic
left a comment
There was a problem hiding this comment.
Did flaky spec runner approve this as well? :)
Member
Author
sure :) https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/1798/ |
Contributor
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: cc @kertal |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Aug 2, 2021
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Aug 2, 2021
Contributor
kibanamachine
added a commit
that referenced
this pull request
Aug 2, 2021
kibanamachine
added a commit
that referenced
this pull request
Aug 2, 2021
streamich
pushed a commit
to vadimkibana/kibana
that referenced
this pull request
Aug 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR stabilizes the check for the number of fetches in Discover, by using a retry.
Flaky test runner said: yes - 1 failure, but not related to this fix
Fixes #105312
Checklist
Delete any items that are not applicable to this PR.