[Reporting CSV] Fix scroll ID bug for deprecated csv export #106892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsullivan
force-pushed
the
reporting/fix-deprecated-csv-export
branch
from
5e2f878
to
215e227
Compare
tsullivan
added
(Deprecated) Feature:Reporting
|
Pinging @elastic/kibana-app-services (Team:AppServices) |
|
Pinging @elastic/kibana-reporting-services (Team:Reporting Services) |
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
tsullivan
added a commit
to tsullivan/kibana
that referenced
this pull request
Jul 30, 2021
…106892) * [Reporting CSV] Fix scroll ID bug for deprecated csv export * fix unit test Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
This was referenced Jul 30, 2021
tsullivan
added a commit
to tsullivan/kibana
that referenced
this pull request
Jul 30, 2021
…106892) * [Reporting CSV] Fix scroll ID bug for deprecated csv export * fix unit test Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
tsullivan
added a commit
to tsullivan/kibana
that referenced
this pull request
Jul 30, 2021
…106892) * [Reporting CSV] Fix scroll ID bug for deprecated csv export * fix unit test Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
tsullivan
added a commit
that referenced
this pull request
Jul 30, 2021
…#107298) * [Reporting CSV] Fix scroll ID bug for deprecated csv export * fix unit test Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
tsullivan
added a commit
that referenced
this pull request
Jul 30, 2021
…#107296) * [Reporting CSV] Fix scroll ID bug for deprecated csv export * fix unit test Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
tsullivan
added a commit
that referenced
this pull request
Jul 30, 2021
…#107295) * [Reporting CSV] Fix scroll ID bug for deprecated csv export * fix unit test Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
streamich
pushed a commit
to vadimkibana/kibana
that referenced
this pull request
Aug 8, 2021
…106892) * [Reporting CSV] Fix scroll ID bug for deprecated csv export * fix unit test Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR follows #102972.
Updating the Elasticsearch client in the Reporting code opened a regression in CSV export where the scroll ID parameter ends up in the query string of the URI of the search.
Initially, the regression was only thought to affect the
csv_searchsourceexport type, but it also affects the older, deprecatedcsvexport type.The deprecated export type is accessible to users only if they have set up automated reports in an earlier version.
Release note:
Fixed a bug where a legacy form of CSV export could fail due to
resource_too_long_exception