[Synthetics] Fix mobile synthetics image clipping

[justinkambic]

Summary

Resolves elastic/uptime#339.

The default sizes we use for images are hardcoded. They work well for landscape-shaped images; portrait-shaped images like the ones produced by mobile emulation are getting clipped by the hardcoded value.

We can limit the width to a max-size and allow height to match. The plus side of this solution is it's very simple, and it works for both image sizes. The drawback is it will reduce the size of the image we show for desktop-style images, but it will not clip anything. Users will also still have the ability to expand the screenshot to see it in the full-screen viewer mode.

This is a minimum-viable fix. I am open to suggestions on how to make this better, especially if it means the existing experience won't change.

Checklist

Delete any items that are not applicable to this PR.

• Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
• Documentation was added for features that require explanation or tutorials
• Unit or functional tests were updated or added to match the most common scenarios
• Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
• Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
• If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
• This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
• This was checked for cross-browser compatibility

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk	Probability	Severity	Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space.	Low	High	Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks.	High	Low	Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled.	Medium	High	Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

• This was checked for breaking API changes and was labeled appropriately

[elasticmachine]

Pinging @elastic/uptime (Team:uptime)

[justinkambic]

I tested this with full screenshot-style monitors as well (as opposed the blocking optimization we introduced for 1.14). Seemed to work fine.

[kibanamachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: d2eea2b
• Storybooks Preview

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
uptime	946.5KB	947.1KB	+571.0B

History

• 💔 Build #139469 failed bb259667ff3c22e63cef618177cf57cf0f17d3a2

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @justinkambic

[paulb-elastic]

Checked this with local build of the branch and it works as expected for the iphone viewport I tried originally:

[dominiqueclarke]

LGTM. I'm wondering, though, if we wanted to do anything to reduce the height of the rows, as they are quite large for device emulation.

[justinkambic]

I'm wondering, though, if we wanted to do anything to reduce the height of the rows, as they are quite large for device emulation.

@dominiqueclarke I am ++ for doing this. I'll create an enhancement request.

EDIT:

Issue here: elastic/uptime#344

[kibanamachine]

💚 Backport successful

Status	Branch	Result
✅	7.14
✅	7.x

The backport PRs will be merged automatically after passing CI.