[TSVB] Refactor the index pattern mode functional test #105725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stratoula
added
Feature:TSVB
stratoula
added
the
Team:Visualizations
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
dej611
approved these changes
Jul 15, 2021
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
stratoula
added a commit
to stratoula/kibana
that referenced
this pull request
Jul 19, 2021
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
stratoula
added a commit
to stratoula/kibana
that referenced
this pull request
Jul 19, 2021
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> # Conflicts: # test/functional/apps/visualize/_tsvb_chart.ts
stratoula
added a commit
that referenced
this pull request
Jul 19, 2021
stratoula
added a commit
that referenced
this pull request
Jul 20, 2021
…6066) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> # Conflicts: # test/functional/apps/visualize/_tsvb_chart.ts Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #99460
Closes #103252
Closes #105316
I think that this test is over complicated without any reason.
What we want to test here is that the two modes (input string mode and combobox mode) work correctly. No need to load an extra dataset. This can be done with existing index patterns.
I have simplified it a bit, so I think that it will remove all flakiness.
100 times FF https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/1732/
100 times Chrome https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/1731/