Skip to content

[Exploratory view] Fix mobile device distribution #104626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 8, 2021
Merged

[Exploratory view] Fix mobile device distribution #104626

merged 4 commits into from
Jul 8, 2021

Conversation

@shahzad31
Copy link
Contributor

@shahzad31 shahzad31 commented Jul 7, 2021 •
edited
Loading

Summary

Fix #104530

Fixed missing metric option in device distribution config

There is also an issue with breakdown which is being fixed in #104630

@shahzad31 shahzad31 self-assigned this Jul 7, 2021
@shahzad31 shahzad31 added v7.14.0 v7.15.0 v8.0.0 release_note:skip Skip the PR/issue when compiling release notes labels Jul 7, 2021
@shahzad31 shahzad31 marked this pull request as ready for review July 7, 2021 12:12
@shahzad31 shahzad31 mentioned this pull request Jul 7, 2021
Merged
@kibanamachine
Copy link
Contributor

kibanamachine commented Jul 7, 2021

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observability 483.4KB 483.5KB +88.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @shahzad31

dominiqueclarke
dominiqueclarke approved these changes Jul 8, 2021
View reviewed changes
Copy link
Contributor

@dominiqueclarke dominiqueclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Screen Shot 2021-07-08 at 11 59 19 AM

@shahzad31 shahzad31 merged commit bde7455 into elastic:master Jul 8, 2021
@shahzad31 shahzad31 deleted the fix-mobile-exp-bug branch July 8, 2021 16:18
@shahzad31 shahzad31 added the auto-backport Deprecated - use backport:version if exact versions are needed label Jul 8, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 8, 2021
@shahzad31 @kibanamachine
[Exploratory view] Fix mobile device distribution (elastic#104626)
5292907
@kibanamachine kibanamachine mentioned this pull request Jul 8, 2021
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 8, 2021
@shahzad31 @kibanamachine
[Exploratory view] Fix mobile device distribution (elastic#104626)
88a0033
@kibanamachine kibanamachine mentioned this pull request Jul 8, 2021
Merged
@kibanamachine
Copy link
Contributor

kibanamachine commented Jul 8, 2021

💚 Backport successful

Status Branch Result
✅ 7.14
✅ 7.x

The backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Jul 8, 2021
@kibanamachine @shahzad31
[Exploratory view] Fix mobile device distribution (#104626) (#104915)
70982ab 
Co-authored-by: Shahzad <shahzad.muhammad@elastic.co>
kibanamachine added a commit that referenced this pull request Jul 8, 2021
@kibanamachine @shahzad31
[Exploratory view] Fix mobile device distribution (#104626) (#104914)
f29056d 
Co-authored-by: Shahzad <shahzad.muhammad@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dominiqueclarke dominiqueclarke dominiqueclarke approved these changes

@bryce-b bryce-b Awaiting requested review from bryce-b

@AlexanderWert AlexanderWert Awaiting requested review from AlexanderWert

Assignees

@shahzad31 shahzad31

Labels

auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes v7.14.0 v7.15.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Exploratory View - iOS "Device Distribution" report is broken

3 participants

@shahzad31 @kibanamachine @dominiqueclarke