[ML] Fix Index Data Visualizer not gracefully handling error #104567
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qn895
added
bug
| // there could be multiple errors | ||
| if (Array.isArray(allStats.errors) && allStats.errors.length > 0) { | ||
| allStats.errors.forEach((err: any) => { | ||
| dataLoader.displayError(err.body?.message?.output?.payload ?? err); |
Member
There was a problem hiding this comment.
it might be worth testing this error with our extractErrorProperties function to see if it displays it extracts the error text correctly, if so, I think we should copy that function over to tis plugin.
The shape of errors returned from es and kibana can depend on where they were thrown from, extractErrorProperties does a decent job of recognising all known error shapes.
Contributor
|
Pinging @elastic/ml-ui (:ml) |
Member
Author
|
@elasticmachine merge upstream |
Member
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: |
qn895
added
the
auto-backport
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 13, 2021
…#104567) * Fix to show better error message * Handle batch errors by still showing as much data as possible * Fix i18n * Fix errors * Fix 404 error, add extractErrorProperties * Fix missing histogram Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 13, 2021
…#104567) * Fix to show better error message * Handle batch errors by still showing as much data as possible * Fix i18n * Fix errors * Fix 404 error, add extractErrorProperties * Fix missing histogram Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Contributor
kibanamachine
added a commit
that referenced
this pull request
Jul 13, 2021
#105463) * Fix to show better error message * Handle batch errors by still showing as much data as possible * Fix i18n * Fix errors * Fix 404 error, add extractErrorProperties * Fix missing histogram Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Quynh Nguyen <43350163+qn895@users.noreply.github.com>
kibanamachine
added a commit
that referenced
this pull request
Jul 13, 2021
#105464) * Fix to show better error message * Handle batch errors by still showing as much data as possible * Fix i18n * Fix errors * Fix 404 error, add extractErrorProperties * Fix missing histogram Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Quynh Nguyen <43350163+qn895@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes #102966 . Previously, when an error occurs, the Index Data Visualizer would show an error message that's not too helpful and would fail to load for all other fields.
Before
Note that because
transaction.duration.histogramfails, all other fields in the index will also failAfter
Here, only the fields in the same batch as
transaction.duration.histogramwould not showChecklist
Delete any items that are not applicable to this PR.