[plugin-helpers] Fix dependency resolution #104556
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This builds on the changes introduced in elastic#104512, fixing dependency resolution for the plugin-helpers CLI. Instead of building a plugin in isolation, this performs plugin discovery and filters the optimizer lisst down to the requested plugin. Testing 1) `cd examples/bfetch_explorer` 1) `node ../../scripts/plugin_helpers build --kibana-version=8.0.0-SNAPSHOT`
jbudz
added
Team:Operations
Contributor
|
Pinging @elastic/kibana-operations (Team:Operations) |
Contributor
💚 Build SucceededMetrics [docs]
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 7, 2021
This builds on the changes introduced in elastic#104512, fixing dependency resolution for the plugin-helpers CLI. Instead of building a plugin in isolation, this performs plugin discovery and filters the optimizer lisst down to the requested plugin. Testing 1) `cd examples/bfetch_explorer` 1) `node ../../scripts/plugin_helpers build --kibana-version=8.0.0-SNAPSHOT`
Contributor
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
kibanamachine
added a commit
that referenced
this pull request
Jul 7, 2021
This builds on the changes introduced in #104512, fixing dependency resolution for the plugin-helpers CLI. Instead of building a plugin in isolation, this performs plugin discovery and filters the optimizer lisst down to the requested plugin. Testing 1) `cd examples/bfetch_explorer` 1) `node ../../scripts/plugin_helpers build --kibana-version=8.0.0-SNAPSHOT` Co-authored-by: Jonathan Budzenski <jon@budzenski.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on the changes introduced in #104512, fixing dependency
resolution for the plugin-helpers CLI. Instead of building a plugin in
isolation, this performs plugin discovery and filters the optimizer
list down to the requested plugin.
Testing
cd examples/bfetch_explorernode ../../scripts/plugin_helpers build --kibana-version=8.0.0-SNAPSHOT