-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RAC] [Cases] Fix responsiveness in Cases UI #103766
Conversation
Pinging @elastic/security-threat-hunting (Team:Threat Hunting) |
Pinging @elastic/security-solution (Team: SecuritySolution) |
@elasticmachine run elasticsearch-ci/docs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this! It is so good to see those fixes. Code LGTM! I tested on iphone 6/7/8 Chrome preset (width 375px) and I found the following:
- The close icon of the timeline is not on the top right. Instead it sticked to the left along with the title and other icons on the left.
- The create case button overflows.
- If you put a long text while editing a tag the tag wrapper overflows the page. Putting
width: 100%
orfullWidth
to theEuiFlexGroup
seems to fix the issue. This will fix another bug where on laptops where if you put a long tag and you press edit the left column gets bigger and pushes the left one.
- Mapping is not properly aligned.
@cnasikas good finds! I fixed all of your points except for: This is not straightforward to fix, and I'd rather not spend time on it unless you think it is very important? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not straightforward to fix, and I'd rather not spend time on it unless you think it is very important?
No, it is not 🙂 ! LGTM! Thanks for the fixes!
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: |
Summary
Resolves #102471
Various fixes for responsive UI issues in Cases. I also noticed that the timeline button at the bottom of the page was not responsive so i fixed that as well.
Timeline before:
Timeline after:
All cases before:
All cases after:
Status filter before:
Status filter after:
Case details before:
Case details after:
Edit case details before:
Edit case details after:
Checklist
Delete any items that are not applicable to this PR.