Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RAC] [Cases] Fix responsiveness in Cases UI #103766

Merged
merged 8 commits into from
Jun 30, 2021

Conversation

stephmilovic
Copy link
Contributor

Summary

Resolves #102471

Various fixes for responsive UI issues in Cases. I also noticed that the timeline button at the bottom of the page was not responsive so i fixed that as well.

Timeline before:

before_tl

Timeline after:

after_tl

All cases before:

before_all

All cases after:

after_all

Status filter before:

before_status

Status filter after:

after_status

Case details before:

before_cd

Case details after:

after_cd

Edit case details before:

before_edit

Edit case details after:

after_edit

Checklist

Delete any items that are not applicable to this PR.

@stephmilovic stephmilovic added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting Security Solution Threat Hunting Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Feature:Cases Cases feature v7.14.0 Feature:Cases-RAC-UI labels Jun 29, 2021
@stephmilovic stephmilovic requested review from a team as code owners June 29, 2021 20:13
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@stephmilovic
Copy link
Contributor Author

@elasticmachine run elasticsearch-ci/docs

@cnasikas cnasikas added the bug Fixes for quality problems that affect the customer experience label Jun 30, 2021
Copy link
Member

@cnasikas cnasikas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! It is so good to see those fixes. Code LGTM! I tested on iphone 6/7/8 Chrome preset (width 375px) and I found the following:

  1. The close icon of the timeline is not on the top right. Instead it sticked to the left along with the title and other icons on the left.

Screenshot 2021-06-30 at 9 42 58 AM

  1. The create case button overflows.

Screenshot 2021-06-30 at 9 32 04 AM

  1. If you put a long text while editing a tag the tag wrapper overflows the page. Putting width: 100% or fullWidth to the EuiFlexGroup seems to fix the issue. This will fix another bug where on laptops where if you put a long tag and you press edit the left column gets bigger and pushes the left one.

Screenshot 2021-06-30 at 9 35 27 AM

  1. Mapping is not properly aligned.

Screenshot 2021-06-30 at 9 43 54 AM

@stephmilovic
Copy link
Contributor Author

@cnasikas good finds! I fixed all of your points except for:
image

This is not straightforward to fix, and I'd rather not spend time on it unless you think it is very important?

Here are the other fixes:
ttt
tttt

Copy link
Member

@cnasikas cnasikas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not straightforward to fix, and I'd rather not spend time on it unless you think it is very important?

No, it is not 🙂 ! LGTM! Thanks for the fixes!

@stephmilovic
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
cases 262 261 -1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
cases 522.7KB 525.4KB +2.6KB
securitySolution 6.3MB 6.3MB -362.0B
total +2.3KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@stephmilovic stephmilovic merged commit 305df3a into elastic:master Jun 30, 2021
@stephmilovic stephmilovic deleted the cases_responsive branch June 30, 2021 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Cases Cases feature release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting Security Solution Threat Hunting Team v7.14.0 v7.15.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RAC] polish cases overview header
4 participants