[Fleet] Fix double policy header layout #103076
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use the default page title without tabs while loading the add integration view
jloleysens
added
v8.0.0
release_note:skip
Contributor
|
Pinging @elastic/fleet (Team:Fleet) |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededMetrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: |
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Jun 24, 2021
* Fix double policy header layout - Use the default page title without tabs while loading the add integration view * remove unused import Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Contributor
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
kibanamachine
added a commit
that referenced
this pull request
Jun 24, 2021
* Fix double policy header layout - Use the default page title without tabs while loading the add integration view * remove unused import Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Jean-Louis Leysens <jloleysens@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix #102939. Looks like this is a regression from a big refactor: #101828
Current implementation adds an explicit check at the
<App />level for whether we are loading the "Add integration" view and replaces the default header layout (see screenshots).How to test
See the linked issues for details on how to reproduce. This requires starting Elastic+Kibana on basic and setting up an agent for data collection.
Also check that existing fleet pages still all look correct while loading. This will require going to the different tabs and pressing refresh while looking for any visual regressions.
To reviewers
useRouteMatchthe correct thing to use here? My testing and understanding of the docs seem to indicate "yes" 🤷🏻♂️Screenshots
Loading "Add integrations"
Notice that tabs from the default layout have been removed for this special case.
"Add integrations" view after these changes are applied