Skip to content

[7.x] Change file data visualizer links to point to new location in home application (#101393) #101844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 9, 2021
Merged

[7.x] Change file data visualizer links to point to new location in home application (#101393) #101844

merged 1 commit into from
Jun 9, 2021

Conversation

@nreese
Copy link
Contributor

@nreese nreese commented Jun 9, 2021

Backports the following commits to 7.x:

@nreese @kibanamachine
Change file data visualizer links to point to new location in home ap…
3861db0 
…plication (elastic#101393)

* Link to home file data visualizer

* remove unused import

* i18n cleanup

* remove unused import from EmptyState

* use const

* remove ml functional test cases checking for ml_file_data_visualizer

* more clean-up of ml_file_data_visualizer

* jest snapshot and nav to home page in no_ml_access tests

* revert change to functional test dual_privileges_all at everything_space

* revert another change to security_and_spaces/tests/catalogue.ts

* revert changes to x-pack/test/ui_capabilities/security_only/tests/catalogue.ts

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
# Conflicts:
#	src/plugins/index_pattern_management/public/components/index_pattern_table/index_pattern_table.tsx
@nreese nreese added the backport This PR is a backport of another PR label Jun 9, 2021
@nreese nreese enabled auto-merge (squash) June 9, 2021 21:56
@nreese nreese mentioned this pull request Jun 9, 2021
Merged
@kibanamachine
Copy link
Contributor

kibanamachine commented Jun 9, 2021

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
indexPatternManagement 165 162 -3

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
indexPatternManagement 46 45 -1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
indexPatternManagement 555.8KB 555.1KB -770.0B
ml 5.8MB 5.8MB -8.0B
total -778.0B

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
indexPatternManagement 4 3 -1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
dataVisualizer 13.6KB 14.3KB +767.0B
indexPatternManagement 14.1KB 13.0KB -1.1KB
ml 66.8KB 65.8KB -1.0KB
total -1.4KB
Unknown metric groups

API count

id before after diff
indexPatternManagement 46 45 -1

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@nreese nreese merged commit f55cfb3 into elastic:7.x Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

backport This PR is a backport of another PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nreese @kibanamachine