Skip to content

[Lens] Stabilize opening of Lens from listing page #101569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 10, 2021
Merged

[Lens] Stabilize opening of Lens from listing page #101569

merged 2 commits into from
Jun 10, 2021

Conversation

@flash1293
Copy link
Contributor

@flash1293 flash1293 commented Jun 8, 2021

Fixes #101451

Makes sure the lens app actually gets rendered when clicking a listing entry

@flash1293 flash1293 added Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Feature:Lens v7.14.0 auto-backport Deprecated - use backport:version if exact versions are needed labels Jun 8, 2021
@flash1293 flash1293 marked this pull request as ready for review June 8, 2021 12:27
@flash1293 flash1293 requested a review from a team June 8, 2021 12:27
@elasticmachine
Copy link
Contributor

elasticmachine commented Jun 8, 2021

Pinging @elastic/kibana-app (Team:KibanaApp)

@flash1293
Copy link
Contributor Author

flash1293 commented Jun 10, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

kibanamachine commented Jun 10, 2021

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lens 1.3MB 1.3MB +26.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@flash1293 flash1293 merged commit fe3c761 into elastic:master Jun 10, 2021
@kibanamachine kibanamachine mentioned this pull request Jun 10, 2021
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jun 10, 2021
@flash1293 @kibanamachine
stabilize opening of Lens from listing page (elastic#101569)
f6f985e
@kibanamachine
Copy link
Contributor

kibanamachine commented Jun 10, 2021

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jun 14, 2021
@kibanamachine
Copy link
Contributor

kibanamachine commented Jun 14, 2021

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jun 14, 2021
kibanamachine added a commit that referenced this pull request Jun 14, 2021
@kibanamachine @flash1293
stabilize opening of Lens from listing page (#101569) (#101903)
f9edb4e 
Co-authored-by: Joe Reuter <johannes.reuter@elastic.co>
@flash1293 flash1293 mentioned this pull request Oct 28, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dej611 dej611 dej611 approved these changes

Assignees

No one assigned

Labels

auto-backport Deprecated - use backport:version if exact versions are needed Feature:Lens release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// v7.14.0 v8.0.0

Projects

None yet

Milestone

No milestone

4 participants

@flash1293 @elasticmachine @kibanamachine @dej611