[ts] migrate x-pack/test to composite ts project
#101441
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spalger
changed the title
x-pack/test to composite ts project
spalger
added
release_note:skip
Contributor
|
Pinging @elastic/kibana-operations (Team:Operations) |
Contributor
|
Pinging @elastic/kibana-qa (Team:QA) |
legrego
approved these changes
Jun 7, 2021
Member
legrego
left a comment
legrego
left a comment
There was a problem hiding this comment.
Spaces/security changes LGTM!
spalger
added
the
auto-backport
mshustov
approved these changes
Jun 8, 2021
jbudz
approved these changes
Jun 8, 2021
…-test-project-ref
Contributor
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
Contributor
💔 Backport failed
To backport manually run: |
spalger
added a commit
to spalger/kibana
that referenced
this pull request
Jun 8, 2021
Co-authored-by: spalger <spalger@users.noreply.github.com> # Conflicts: # x-pack/test/functional/page_objects/gis_page.ts # x-pack/test/functional/page_objects/index.ts # x-pack/test/functional/page_objects/reporting_page.ts
spalger
added a commit
that referenced
this pull request
Jun 8, 2021
Co-authored-by: spalger <spalger@users.noreply.github.com> # Conflicts: # x-pack/test/functional/page_objects/gis_page.ts # x-pack/test/functional/page_objects/index.ts # x-pack/test/functional/page_objects/reporting_page.ts
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jun 9, 2021
* master: (54 commits) Implement "select all" rules feature (elastic#100554) [ML] Remove script fields from the Anomaly detection alerting rule executor (elastic#101607) [Security solutions][Endpoint] Update event filtering texts (elastic#101563) [Enterprise Search] Mocks/tests tech debt - avoid hungry mocking (elastic#101107) [FTR] Updates esArchive paths [FTR] Updates esArchive paths [Security Solution][Detection Engine] Adds runtime field tests (elastic#101664) Added APM PHP agent to the list of agent names (elastic#101062) [CI] Restore old version_info behavior when .git directory is present (elastic#101642) [Fleet] Add fleet server telemetry (elastic#101400) [APM] Syncs agent config settings to APM Fleet policies (elastic#100744) [esArchiver] drop support for --dir, use repo-relative paths instead (elastic#101345) Revert "[xpack/test] restore incremental: false in ts project" [Security Solution] Remove Host Isolation feature flag (elastic#101655) [xpack/test] restore incremental: false in ts project [DOCS] Adds link to video landing page (elastic#101413) [ML] Move Index Data Visualizer into separate plugin (Part 1) (elastic#100922) Improve security plugin return types (elastic#101492) [ts] migrate `x-pack/test` to composite ts project (elastic#101441) [App Search] Updated Search UI to new URL (elastic#101320) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compliment to #99148
Migrates the
x-pack/testdirectory to a composite TS project which can be ref'd from other composite projects. This gets us closer to having all projects in the repo be composite and required far fewer changes than the OSS tests because many of the services/pageObjects in thex-pack/testproject already return POJOs from their providers rather than returning instances of class expressions, though a few of those were in use and were extracted to sub-classes ofFtrService. POJOs were left in place to reduce the amount of changes necessary to be reviewed.