Skip to content

Conversation

@tsullivan
Copy link
Member

@tsullivan tsullivan commented Jun 3, 2021

Summary

This PR removes ESQueue from Reporting and backports #64853 to the 7.x branch. Kibana stays compatible with pending reports that were scheduled with ESQueue in an earlier 7.x version by polling for report documents that do not have a kibanaVersion field.

Testing:

Queue up a bunch of reports while running the current 7.x. While some reports are still pending, switch the code to this PR branch, and restart Kibana. The pending reports should be "migrated" by being detected in the reports:monitor task and rescheduled as tasks with Task Manager.

@tsullivan tsullivan force-pushed the reporting/tm-backport-7x branch 9 times, most recently from f505322 to 6c0a214 Compare June 11, 2021 01:21
@tsullivan tsullivan force-pushed the reporting/tm-backport-7x branch from 6c0a214 to eea4d1f Compare June 11, 2021 22:22
@tsullivan tsullivan force-pushed the reporting/tm-backport-7x branch from eea4d1f to 203b2ed Compare June 15, 2021 17:55
@tsullivan
Copy link
Member Author

@elasticmachine merge upstream

@tsullivan tsullivan force-pushed the reporting/tm-backport-7x branch from 392c8d3 to e5baf10 Compare June 21, 2021 20:31
@tsullivan tsullivan force-pushed the reporting/tm-backport-7x branch from e5baf10 to 07bd221 Compare June 23, 2021 19:10
@tsullivan tsullivan marked this pull request as ready for review June 23, 2021 19:15
@tsullivan tsullivan added backport This PR is a backport of another PR v7.14.0 zDeprecated Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead labels Jun 23, 2021
@tsullivan
Copy link
Member Author

@elasticmachine merge upstream

@tsullivan
Copy link
Member Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
reporting 123 131 +8

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
reporting 17 18 +1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
reporting 85.4KB 85.5KB +24.0B
Unknown metric groups

API count

id before after diff
reporting 124 132 +8

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@tsullivan tsullivan merged commit 0f4e999 into elastic:7.x Jun 24, 2021
@tsullivan tsullivan deleted the reporting/tm-backport-7x branch June 24, 2021 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR v7.14.0 zDeprecated Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants