Skip to content

[Security solution][Endpoint] Add back button when to the event filters list #101280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 9, 2021
Merged

[Security solution][Endpoint] Add back button when to the event filters list #101280

merged 4 commits into from
Jun 9, 2021

Conversation

@dasansol92
Copy link
Contributor

@dasansol92 dasansol92 commented Jun 3, 2021

Summary

Add back button when to the event filters list.
Also, isolated back to external app button to be used as generic component

event filter back to fleet button

For maintainers

@dasansol92
Add back button when to the event filters list. Isolated back to exte…
2464de0 
…rnal app button to be used as generic component
@dasansol92 dasansol92 requested a review from a team as a code owner June 3, 2021 14:11
@dasansol92 dasansol92 added auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v7.14.0 v8.0.0 labels Jun 3, 2021
@elasticmachine
Copy link
Contributor

elasticmachine commented Jun 3, 2021

Pinging @elastic/security-onboarding-and-lifecycle-mgt (Team:Onboarding and Lifecycle Mgt)

@dasansol92 dasansol92 mentioned this pull request Jun 3, 2021
Closed
@dasansol92 dasansol92 changed the title Add back button when to the event filters list [Security solution][Endpoint] Add back button when to the event filters list Jun 4, 2021
paul-tavares
paul-tavares approved these changes Jun 4, 2021
View reviewed changes
Copy link
Contributor

@paul-tavares paul-tavares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NICE! 🔥

We probably should also add a test case to the page view to ensure this is covered. Or maybe a end-to-end FTR test case to ensure we "touch" the fleet page.

@dasansol92
Copy link
Contributor Author

dasansol92 commented Jun 4, 2021

@paul-tavares added unit tests

@dasansol92 dasansol92 requested a review from paul-tavares June 7, 2021 07:49
@dasansol92
Copy link
Contributor Author

dasansol92 commented Jun 7, 2021

@elasticmachine merge upstream

ashokaditya
ashokaditya approved these changes Jun 8, 2021
View reviewed changes
Copy link
Member

@ashokaditya ashokaditya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 LGTM. I only have nitpicks. Feel free to ignore if not relevant 😄

...ecurity_solution/public/management/pages/event_filters/view/event_filters_list_page.test.tsx
});
});

describe('and the back button is present', () => {
Copy link
Member

@ashokaditya ashokaditya Jun 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: Maybe just call this Back button since now it looks similar to the test description name below.

Copy link
Contributor Author

@dasansol92 dasansol92 Jun 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to merge this before having more out of date check errors and will do this change in next pr :)

...ins/security_solution/public/management/pages/event_filters/view/event_filters_list_page.tsx
if (routeState && routeState.onBackButtonNavigateTo) {
return <BackToExternalAppButton {...routeState} />;
}
return null;
Copy link
Member

@ashokaditya ashokaditya Jun 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: does headerComponent expect a null instead of undefined?

Copy link
Contributor Author

@dasansol92 dasansol92 Jun 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's an optional component, so null works in this case

paul-tavares
paul-tavares approved these changes Jun 8, 2021
View reviewed changes
Copy link
Contributor

@paul-tavares paul-tavares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dasansol92
Copy link
Contributor Author

dasansol92 commented Jun 9, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

kibanamachine commented Jun 9, 2021

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
securitySolution 2236 2238 +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 6.9MB 6.9MB +309.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@dasansol92 dasansol92 merged commit e94a34d into elastic:master Jun 9, 2021
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Jun 9, 2021
@dasansol92 @kibanamachine
[Security solution][Endpoint] Add back button when to the event filte…
ca1b42e 
…rs list (elastic#101280)

* Add back button when to the event filters list. Isolated back to external app button to be used as generic component

* Adds unit tests for back button

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine kibanamachine mentioned this pull request Jun 9, 2021
Merged
@kibanamachine
Copy link
Contributor

kibanamachine commented Jun 9, 2021

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Jun 9, 2021
@kibanamachine @dasansol92
[Security solution][Endpoint] Add back button when to the event filte…
f9ca6ff 
…rs list (#101280) (#101727)

* Add back button when to the event filters list. Isolated back to external app button to be used as generic component

* Adds unit tests for back button

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: David Sánchez <davidsansol92@gmail.com>
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jun 9, 2021
@gmmorris
Merge branch 'master' into task-manager/capacity-estimation
53e584b 
* master:
  clarify which parts of TM are experimental (elastic#101757)
  Add sh scripts with _bulk_action route usage examples (elastic#101736)
  [Uptime] Only register route in side nav if uptime show capability is true (elastic#101709)
  Use KIBANA_DOCS in doc link service (elastic#101667)
  [Alerting][Event log] Persisting duration information for active alerts in event log (elastic#101387)
  Address design issues in Discover/Graph (elastic#101584)
  Optimize performance for document table (elastic#101715)
  Change file data visualizer links to point to new location in home application (elastic#101393)
  [Fleet] Tighten policy permissions, take II (elastic#97366)
  [ML] Add debounce to the severity control update  (elastic#101581)
  [Fleet] Fix routing issues with `getPath` and `history.push` (elastic#101658)
  [APM] Add link-to/transaction route (elastic#101731)
  [Index Patterns] Runtime fields CRUD REST API  (elastic#101164)
  [ILM] Refactor types and fix missing aria labels (elastic#101518)
  [Lens] New summary row feature for datatable (elastic#101075)
  Blocks save event filter with a white space name (elastic#101599)
  Improve security server types (elastic#101661)
  [APM] Replace side nav with tabs on Settings page (elastic#101460)
  [APM] Only register items in side nav if user has permissions to see app (elastic#101707)
  [Security solution][Endpoint] Add back button when to the event filters list (elastic#101280)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ashokaditya ashokaditya ashokaditya approved these changes

@paul-tavares paul-tavares paul-tavares approved these changes

Assignees

No one assigned

Labels

auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v7.14.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@dasansol92 @elasticmachine @kibanamachine @ashokaditya @paul-tavares