Skip to content

Conversation

@spalger
Copy link
Contributor

@spalger spalger commented May 25, 2021

In order to migrate the root test directory to its own TypeScript project that can be ref'd we need to stop returning class expressions from provider functions. Part of #99148

Migrates the "MenuToggle" service to the new FtrService class. Unlike other services this service returned a class which was bound to other services via the provider, and was then instantiated by other services/page objects with unique options when used. This model is entirely flawed and not supported because it relies on using class expressions to define classes which are bound to variables in scope. I have instead moved this to a more classical service class with a create() method, which returns a simple object with open() and close() methods which will allow opening and closing a specific menu.

@spalger spalger added auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes v7.14.0 v8.0.0 Team:QA Platform QA t// labels May 27, 2021
@spalger spalger requested a review from dmlemeshko May 27, 2021 22:59
@spalger spalger marked this pull request as ready for review May 27, 2021 22:59
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-qa (Team:QA)

@spalger
Copy link
Contributor Author

spalger commented May 27, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

References to deprecated APIs

id before after diff
canvas 29 25 -4
crossClusterReplication 8 6 -2
fleet 22 20 -2
globalSearch 4 2 -2
indexManagement 12 7 -5
infra 261 149 -112
lens 67 45 -22
licensing 18 15 -3
lists 239 236 -3
maps 286 208 -78
ml 121 115 -6
monitoring 109 56 -53
securitySolution 386 342 -44
stackAlerts 101 95 -6
total -342

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Member

@dmlemeshko dmlemeshko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmlemeshko dmlemeshko merged commit 9538788 into elastic:master May 28, 2021
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request May 28, 2021
Co-authored-by: spalger <spalger@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request May 28, 2021
…0847)

Co-authored-by: spalger <spalger@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Spencer <email@spalger.com>
Co-authored-by: spalger <spalger@users.noreply.github.com>
@spalger spalger deleted the migrate/ftr-service-class/menu-toggle branch May 28, 2021 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:QA Platform QA t// v7.14.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants