[ftr] migrate "MenuToggle" service to FtrService class #100608
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to migrate the root
testdirectory to its own TypeScript project that can be ref'd we need to stop returning class expressions from provider functions. Part of #99148Migrates the "MenuToggle" service to the new
FtrServiceclass. Unlike other services this service returned a class which was bound to other services via the provider, and was then instantiated by other services/page objects with unique options when used. This model is entirely flawed and not supported because it relies on using class expressions to define classes which are bound to variables in scope. I have instead moved this to a more classical service class with acreate()method, which returns a simple object withopen()andclose()methods which will allow opening and closing a specific menu.