[ftr] migrate AppsMenuService to FtrService class #100588
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@elasticmachine merge upstream |
spalger
added
release_note:skip
Contributor
|
Pinging @elastic/kibana-qa (Team:QA) |
…ervice-class/apps-menu
…ervice-class/apps-menu
dmlemeshko
approved these changes
May 26, 2021
Member
dmlemeshko
left a comment
dmlemeshko
left a comment
There was a problem hiding this comment.
Code LGTM. Let's wait for CI
Contributor
💚 Build SucceededMetrics [docs]Unknown metric groupsReferences to deprecated APIs
History
To update your PR or re-run it, just comment with: |
spalger
added
the
auto-backport
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
May 26, 2021
Co-authored-by: spalger <spalger@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Contributor
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
kibanamachine
added a commit
that referenced
this pull request
May 26, 2021
Co-authored-by: spalger <spalger@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Spencer <email@spalger.com> Co-authored-by: spalger <spalger@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to migrate the root
testdirectory to its own TypeScript project that can be ref'd we need to stop returning class expressions from provider functions. Part of #99148Migrates the
appMenuservice to the newFtrServiceclass, basically just extracted the class from the provider and remapped services/PageObjects referenced in scope to access private properties on the service instance. Viewing changes with whitespace disabled will help with review.