[ML] Fix missing selected-interval styling for Explorer anomaly charts and mismatched scheduled markers styling #100272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qn895
added
bug
Contributor
|
Pinging @elastic/ml-ui (:ml) |
peteharverson
approved these changes
May 18, 2021
Contributor
peteharverson
left a comment
peteharverson
left a comment
There was a problem hiding this comment.
Tested latest edits and LGTM
Member
Author
|
@elasticmachine merge upstream |
qn895
changed the title
peteharverson
approved these changes
May 24, 2021
Contributor
peteharverson
left a comment
peteharverson
left a comment
There was a problem hiding this comment.
Latest edits for scheduled event markers LGTM
Contributor
💚 Build SucceededMetrics [docs]Async chunks
Unknown metric groupsReferences to deprecated APIs
History
To update your PR or re-run it, just comment with: cc @qn895 |
qn895
added a commit
to qn895/kibana
that referenced
this pull request
May 24, 2021
…s and mismatched scheduled markers styling (elastic#100272) * [ML] Fix missing selected-interval sass * [ML] Only show interval box in explorer page and not in dashboard * [ML] Remove console * [ML] Move showSelectedInterval up * [ML] Update snapshot * [ML] Update styling of scheduled events to match and to be visible Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
qn895
added a commit
that referenced
this pull request
May 24, 2021
…s and mismatched scheduled markers styling (#100272) (#100479) * [ML] Fix missing selected-interval sass * [ML] Only show interval box in explorer page and not in dashboard * [ML] Remove console * [ML] Move showSelectedInterval up * [ML] Update snapshot * [ML] Update styling of scheduled events to match and to be visible Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
qn895
added a commit
to qn895/kibana
that referenced
this pull request
Jun 7, 2021
…s and mismatched scheduled markers styling (elastic#100272) * [ML] Fix missing selected-interval sass * [ML] Only show interval box in explorer page and not in dashboard * [ML] Remove console * [ML] Move showSelectedInterval up * [ML] Update snapshot * [ML] Update styling of scheduled events to match and to be visible Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
qn895
added a commit
that referenced
this pull request
Jun 7, 2021
…s and mismatched scheduled markers styling (#100272) (#101530) * [ML] Fix missing selected-interval sass * [ML] Only show interval box in explorer page and not in dashboard * [ML] Remove console * [ML] Move showSelectedInterval up * [ML] Update snapshot * [ML] Update styling of scheduled events to match and to be visible Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
|
Are you sure this should have |
qn895
added
release_note:fix
and removed
release_note:skip
Member
Author
|
@LeeDr Thanks for catching that 🙏 I updated the label. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes missing
selected-intervalstyling for anomaly charts in the explorer page as well as mismatched scheduled events styling #99450, which was introduced by #94396After:
