Open
Description
openedon Oct 5, 2020
By default, Kibana plugins are provided with a Logger instance that is already configured with a context name of the format plugins.<pluginId>
. However, some plugins are creating child loggers that ALSO add the plugin's ID, resulting in a context like plugins.<pluginId>.<pluginId>
.
This is unnecessary and should be removed. Here are some plugins currently doing this:
- taskManager (@elastic/kibana-alerting-services):
- securitySolution (@elastic/siem): https://github.com/elastic/kibana/blob/master/x-pack/plugins/security_solution/server/plugin.ts#L126
First, we should definitely fix the offending plugins. But second, we could improve the developer experience here by logging a warning (in development?) when a logger.getLogger
is called with a consecutive duplicate context name.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment