Skip to content

[ML] Invalid actions pattern on Transforms management table #70383

@thompsongl

Description

@thompsongl

Upgrading EUI to its latest version (#70243, not yet merged) highlights a component composition pattern that is now incompatible with EUI.

Screen Shot 2020-06-30 at 4 38 44 PM

The TransformsManagement component table row actions (Start, Edit, and Delete) use a pattern where the form component (inside either a modal or a flyout) is rendered from within the actions menu. When the menu closes, the form component is unmounted and closes.
EUI altered this category of table actions menu to close by default after an item action has been taken.

The result is that the Start, Edit, and Delete actions cannot be taken, as the launched components are immediately unmounted.

Any workarounds result in event propagation and focus management issues due to the React portal component tree. Our recommendation is to move the Start, Edit, and Delete form components outside of the menu actions themselves to be renedered by a parent with "higher" state.

EUI could mitigate the problem on a temporary basis by providing an opt-out option for the new behavior. This would require a new release, and the added prop would eventually be deprecated.

Happy to discuss, explain more, or give a demo.

cc// @walterra @peteharverson @alvarezmelissa87

Metadata

Metadata

Assignees

Labels

:mlFeature:TransformsTransformsbugFixes for quality problems that affect the customer experiencev7.9.0

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions