-
Notifications
You must be signed in to change notification settings - Fork 8.5k
Closed
Labels
Feature:EmbeddingEmbedding content via iFrameEmbedding content via iFrameTeam:PresentationPresentation Team for Dashboard, Input Controls, and Canvas t//Presentation Team for Dashboard, Input Controls, and Canvas t//bugFixes for quality problems that affect the customer experienceFixes for quality problems that affect the customer experienceimpact:highAddressing this issue will have a high level of impact on the quality/strength of our product.Addressing this issue will have a high level of impact on the quality/strength of our product.loe:mediumMedium Level of EffortMedium Level of Effortrelease_note:enhancement
Description
Updating the explicit input of an embeddable in a container does not cause the embeddable panel to re-render that embeddable.
This has caused a number of problems recently:
- After editing a lens embeddable by value, upon returning to the dashboard, a new id must be generated and the entire panel must be replaced.
- The dashboard by value example won't respond properly to input updates on its children
- Showing a placeholder when cloning a panel requires that a new id be generated, and that the placeholder is completely deleted after loading is finished.
Fixing this issue may require changes in multiple places, but the system should be able to support:
- The type of a panel changing, while retaining the same embeddable ID. This means changing the factory.
- The savedObjectId changing should trigger the loading of the new saved object.
- In 'by value' cases, changing out the attributes should properly cause a re-render.
Metadata
Metadata
Assignees
Labels
Feature:EmbeddingEmbedding content via iFrameEmbedding content via iFrameTeam:PresentationPresentation Team for Dashboard, Input Controls, and Canvas t//Presentation Team for Dashboard, Input Controls, and Canvas t//bugFixes for quality problems that affect the customer experienceFixes for quality problems that affect the customer experienceimpact:highAddressing this issue will have a high level of impact on the quality/strength of our product.Addressing this issue will have a high level of impact on the quality/strength of our product.loe:mediumMedium Level of EffortMedium Level of Effortrelease_note:enhancement