The operations team shipped built-in log rotations at #49750. It doesn't make sense to migrate the legacy version since we want to provide log rotation capability in the form of a separate appender.

Requirements

log4j2 version has quite a big API surface https://logging.apache.org/log4j/2.x/manual/appenders.html#RollingFileAppender
From the very beginning, we are going to support a limited sub-set of API to cover the Audit Logging use-case. Requirements from @jportner :

• Define different log rotation config for each appender (e.g., one for stdout and a separate one for audit logging)
• Specify a rolling policy that is size-based or time-based
• For time-based rolling, specify whether or not to modulate (align rolls on the day boundary as opposed to every twenty-four hours)
• Specify a retention period that is number-based or time-based

The other options that Elasticsearch provides (such as strategy action conditions, file name, etc.) are nice-to-have, but not hard requirements to fulfill for Audit Logging.

LP migration

When we stop maintaining the LP logging system we should cont contact the Cloud team to use the new appender instead of legacy log-rotation.