Skip to content

[APM] Dark mode issues in APM UI components #30048

@formgeist

Description

@formgeist

Summary

Depends on: #29725

This issue is meant to track the issues we're facing with dark mode in our current styled components in APM UI.

Basic implementation:

import { EuiThemeProvider } from '../../../observability/public/typings/eui_styled_components';

function bootstrapApp() {
  const [darkMode] = useUiSetting$<boolean>('theme:darkMode');
  return (
    <EuiThemeProvider darkMode={darkMode}>
      <App />
    </EuiThemeProvider>
  );
}

function MyComponent() {
  const CustomLink = styled(EuiLink)`
    margin-right: ${({ theme }) => theme.eui.euiSizeS};
  `;
}

Fixed issues

Fixed in #69362 & #69493

Screenshot 2019-02-04 at 16.39.50.png

  • Timeline: Span row hover is white

Screenshot 2019-02-05 at 09.04.22.png

  • Timeline: Span row lines and vertical markers are white

Screenshot 2019-02-05 at 10.55.46.png

  • Stacktrace source code boxes have white background

screenshot 2019-02-05 at 14 09 24

  • Errors detail: Error occurrence panel has white border

Screenshot 2019-02-05 at 10.57.01.png

  • Contextual info table: Row lines are white

Screenshot 2019-02-05 at 10.57.44.png

  • Service map: The entire map does not support the dark mode theme, but some controls are converted.

screencapture-localhost-5601-ger-s-casper-app-apm-2020-05-14-13_13_39

Screenshot 2020-06-18 at 09 54 24

Open issues

Screenshot 2019-02-05 at 09.03.34.png

  • Charts: X-axis and gridlines are light grey/white instead of darker grey

Screenshot 2019-02-05 at 09.05.34.png

  • Charts: X-axis ticks on distribution barchart are also light grey instead of dark

Screenshot 2019-02-05 at 09.06.29.png

  • Charts: Time selection colour is black

Kapture 2019-02-05 at 11.38.07.gif

Screenshot 2020-06-18 at 09 52 40

Screenshot 2020-06-18 at 10 02 17

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions