Skip to content

[data.search] Remove total hits shimming (legacyHitsTotal) #186144

Open

Description

Summary:

A long time ago in an Elastic Stack far, far away, the format that Elasticsearch returned the total number of hits in a search response changed. Prior to the change, the number of hits was always returned, and after the change, you could opt in/out to receiving the exact number of hits vs. a range.

During this period of time, we updated the data.search services to have a property, legacyHitsTotal, to preserve the existing format for the hits count. As that change was a very long time ago, and as we are trying to remove server-side processing of responses to get to a point where we can stream the response directly to the client, we need to remove this special handling. We also need to verify that consumers that are displaying the count don't have any regressions in displaying the counts (or ranges) correctly.

Related: #55974, #91742

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

Labels

Feature:SearchQuerying infrastructure in KibanaTeam:DataDiscoveryDiscover App Team (Document Explorer, Saved Search, Surrounding documents, Data, DataViews)choreimpact:lowAddressing this issue will have a low level of impact on the quality/strength of our product.loe:smallSmall Level of Efforttechnical debtImprovement of the software architecture and operational architecture

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions